mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fx-compat: DB.executeTransaction() no longer takes generator functions

Browse source
This commit is contained in:
Dan Stillman 2020-07-05 06:20:01 -04:00
parent ccbc785499
commit 03242e8984
41 changed files with 319 additions and 320 deletions
Download patch file Download diff file Expand all files Collapse all files

28
test/tests/itemTreeTest.js
View file

@ -373,8 +373,8 @@ describe("Zotero.ItemTree", function() {
// Remove item
var treeRow = itemsView.getRow(2);
yield Zotero.DB.executeTransaction(function* () {
yield collection.removeItems([treeRow.ref.id]);
yield Zotero.DB.executeTransaction(async function () {
await collection.removeItems([treeRow.ref.id]);
}.bind(this));
// Selection should stay on third row
@ -414,12 +414,12 @@ describe("Zotero.ItemTree", function() {
}
var num = numVisibleRows + 10;
yield Zotero.DB.executeTransaction(function* () {
yield Zotero.DB.executeTransaction(async function () {
for (let i = 0; i < num; i++) {
let title = getTitle(i, num);
let item = createUnsavedDataObject('item', { title });
item.addToCollection(collection.id);
yield item.save();
await item.save();
}
}.bind(this));
@ -436,12 +436,12 @@ describe("Zotero.ItemTree", function() {
skipSelect: true
});
// Then add a few more in a transaction
yield Zotero.DB.executeTransaction(function* () {
yield Zotero.DB.executeTransaction(async function () {
for (let i = 0; i < 3; i++) {
var item = createUnsavedDataObject(
'item', { title: getTitle(0, num), collections: [collection.id] }
);
yield item.save({
await item.save({
skipSelect: true
});
}
@ -465,12 +465,12 @@ describe("Zotero.ItemTree", function() {
}
var num = numVisibleRows + 10;
yield Zotero.DB.executeTransaction(function* () {
yield Zotero.DB.executeTransaction(async function () {
for (let i = 0; i < num; i++) {
let title = getTitle(i, num);
let item = createUnsavedDataObject('item', { title });
item.addToCollection(collection.id);
yield item.save();
await item.save();
}
}.bind(this));
@ -490,12 +490,12 @@ describe("Zotero.ItemTree", function() {
skipSelect: true
});
// Then add a few more in a transaction
yield Zotero.DB.executeTransaction(function* () {
yield Zotero.DB.executeTransaction(async function () {
for (let i = 0; i < 3; i++) {
var item = createUnsavedDataObject(
'item', { title: getTitle(0, num), collections: [collection.id] }
);
yield item.save({
await item.save({
skipSelect: true
});
}
@ -521,13 +521,13 @@ describe("Zotero.ItemTree", function() {
}
var num = numVisibleRows + 10;
yield Zotero.DB.executeTransaction(function* () {
yield Zotero.DB.executeTransaction(async function () {
// Start at "*1" so we can add items before
for (let i = 1; i < num; i++) {
let title = getTitle(i, num);
let item = createUnsavedDataObject('item', { title });
item.addToCollection(collection.id);
yield item.save();
await item.save();
}
}.bind(this));
@ -542,12 +542,12 @@ describe("Zotero.ItemTree", function() {
skipSelect: true
});
// Then add a few more in a transaction
yield Zotero.DB.executeTransaction(function* () {
yield Zotero.DB.executeTransaction(async function () {
for (let i = 0; i < 3; i++) {
var item = createUnsavedDataObject(
'item', { title: getTitle(0, num), collections: [collection.id] }
);
yield item.save({
await item.save({
skipSelect: true
});
}