XUL -> JS tree megacommit
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
https://github.com/zotero/zotero/compare/bb220ad0f2d6bf0eca6df6d225d3d358cb50a27b...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
2020-06-03 07:29:46 +00:00
|
|
|
/*
|
|
|
|
***** BEGIN LICENSE BLOCK *****
|
|
|
|
|
2021-04-09 09:00:34 +00:00
|
|
|
Copyright © 2020 Corporation for Digital Scholarship
|
|
|
|
Vienna, Virginia, USA
|
XUL -> JS tree megacommit
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
https://github.com/zotero/zotero/compare/bb220ad0f2d6bf0eca6df6d225d3d358cb50a27b...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
2020-06-03 07:29:46 +00:00
|
|
|
http://zotero.org
|
|
|
|
|
|
|
|
This file is part of Zotero.
|
|
|
|
|
|
|
|
Zotero is free software: you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU Affero General Public License as published by
|
|
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
Zotero is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU Affero General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU Affero General Public License
|
|
|
|
along with Zotero. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
***** END LICENSE BLOCK *****
|
|
|
|
*/
|
|
|
|
|
|
|
|
const { TreeSelectionStub } = require('components/virtualized-table');
|
|
|
|
const React = require('react');
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Common methods for Zotero.ItemTree and Zotero.CollectionTree
|
|
|
|
* @type {Zotero.LibraryTree}
|
|
|
|
*/
|
|
|
|
var LibraryTree = class LibraryTree extends React.Component {
|
|
|
|
constructor(props) {
|
|
|
|
super(props);
|
|
|
|
this._rows = [];
|
|
|
|
this._rowMap = {};
|
|
|
|
|
|
|
|
this.domEl = props.domEl;
|
|
|
|
this._ownerDocument = props.domEl.ownerDocument;
|
|
|
|
|
2021-04-09 07:47:39 +00:00
|
|
|
this.onSelect = this.createEventBinding('select');
|
|
|
|
this.onRefresh = this.createEventBinding('refresh');
|
XUL -> JS tree megacommit
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
https://github.com/zotero/zotero/compare/bb220ad0f2d6bf0eca6df6d225d3d358cb50a27b...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
2020-06-03 07:29:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
get window() {
|
|
|
|
return this._ownerDocument.defaultView;
|
|
|
|
}
|
2021-08-29 02:43:09 +00:00
|
|
|
|
XUL -> JS tree megacommit
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
https://github.com/zotero/zotero/compare/bb220ad0f2d6bf0eca6df6d225d3d358cb50a27b...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
2020-06-03 07:29:46 +00:00
|
|
|
get selection() {
|
|
|
|
return this.tree ? this.tree.selection : TreeSelectionStub;
|
|
|
|
}
|
|
|
|
|
|
|
|
get rowCount() {
|
|
|
|
return this._rows.length;
|
|
|
|
}
|
|
|
|
|
|
|
|
waitForSelect() {
|
|
|
|
return this._waitForEvent('select');
|
|
|
|
}
|
|
|
|
|
|
|
|
componentDidCatch(error, info) {
|
|
|
|
// Async operations might attempt to update the react components
|
|
|
|
// after window close in tests, which will cause unnecessary crashing
|
|
|
|
// so we set an unintialized flag that we check in select functions
|
|
|
|
// like #notify
|
|
|
|
if (this._uninitialized) return;
|
|
|
|
Zotero.debug("ItemTree: React threw an error");
|
|
|
|
Zotero.logError(error);
|
|
|
|
Zotero.debug(info);
|
|
|
|
if (this.type == 'item') Zotero.Prefs.clear('lastViewedFolder');
|
|
|
|
Zotero.crash();
|
|
|
|
}
|
2021-08-29 02:43:09 +00:00
|
|
|
|
|
|
|
focus() {
|
|
|
|
this.tree.focus();
|
|
|
|
// If no rows selected, select first visible row
|
|
|
|
if (!this.tree.selection.count) {
|
|
|
|
this.tree.selection.select(
|
|
|
|
// TODO: Return -1 when no rows, and skip selection here
|
|
|
|
this.tree._jsWindow.getFirstVisibleRow()
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
XUL -> JS tree megacommit
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
https://github.com/zotero/zotero/compare/bb220ad0f2d6bf0eca6df6d225d3d358cb50a27b...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
2020-06-03 07:29:46 +00:00
|
|
|
|
|
|
|
getParentIndex = (index) => {
|
|
|
|
var thisLevel = this.getLevel(index);
|
|
|
|
if (thisLevel == 0) return -1;
|
|
|
|
for (var i = index - 1; i >= 0; i--) {
|
|
|
|
if (this.getLevel(i) < thisLevel) {
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
getLevel(index) {
|
|
|
|
return this._rows[index].level;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Return a reference to the tree row at a given row
|
|
|
|
*
|
|
|
|
* @return {TreeRow}
|
|
|
|
*/
|
|
|
|
getRow(index) {
|
|
|
|
return this._rows[index];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Return the index of the row with a given ID (e.g., "C123" for collection 123)
|
|
|
|
*
|
|
|
|
* @param {String} - Row id
|
|
|
|
* @return {Integer|false}
|
|
|
|
*/
|
|
|
|
getRowIndexByID(id) {
|
|
|
|
if (!(id in this._rowMap)) {
|
|
|
|
Zotero.debug(`${this.name}: Trying to access a row with invalid ID ${id}`)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return this._rowMap[id];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Add a tree row to the main array, update the row count, tell the treebox that the row
|
|
|
|
* count changed, and update the row map
|
|
|
|
*
|
|
|
|
* @param {TreeRow} treeRow
|
|
|
|
* @param {Number} [beforeRow] - Row index to insert new row before
|
|
|
|
*/
|
|
|
|
_addRow(treeRow, beforeRow, skipRowMapRefresh) {
|
|
|
|
this._rows.splice(beforeRow, 0, treeRow);
|
|
|
|
if (!skipRowMapRefresh) {
|
|
|
|
// Increment all rows in map at or above insertion point
|
|
|
|
for (let i in this._rowMap) {
|
|
|
|
if (this._rowMap[i] >= beforeRow) {
|
|
|
|
this._rowMap[i]++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Add new row to map
|
|
|
|
this._rowMap[treeRow.id] = beforeRow;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
_removeRows(rows) {
|
|
|
|
rows = Zotero.Utilities.arrayUnique(rows);
|
|
|
|
rows.sort((a, b) => a - b);
|
|
|
|
for (let i = rows.length - 1; i >= 0; i--) {
|
|
|
|
this._removeRow(rows[i], true);
|
|
|
|
}
|
|
|
|
this._refreshRowMap();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Remove a row from the main array and parent row children arrays,
|
|
|
|
* delete the row from the map, and optionally update all rows above it in the map
|
|
|
|
*/
|
|
|
|
_removeRow(index, skipMapUpdate) {
|
|
|
|
var id = this.getRow(index).id;
|
|
|
|
let level = this.getLevel(index);
|
|
|
|
|
2021-04-23 10:03:10 +00:00
|
|
|
if (index <= this.selection.focused) {
|
|
|
|
this.selection.select(this.selection.focused - 1);
|
XUL -> JS tree megacommit
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
https://github.com/zotero/zotero/compare/bb220ad0f2d6bf0eca6df6d225d3d358cb50a27b...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
2020-06-03 07:29:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
this._rows.splice(index, 1);
|
|
|
|
if (index != 0
|
|
|
|
&& this.getLevel(index - 1) < level
|
|
|
|
&& (!this._rows[index] || this.getLevel(index) != level)) {
|
|
|
|
this._rows[index - 1].isOpen = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
delete this._rowMap[id];
|
|
|
|
if (!skipMapUpdate) {
|
|
|
|
for (let i in this._rowMap) {
|
|
|
|
if (this._rowMap[i] > index) {
|
|
|
|
this._rowMap[i]--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
_refreshRowMap() {
|
|
|
|
var rowMap = {};
|
|
|
|
for (var i = 0; i < this.rowCount; i++) {
|
|
|
|
let row = this.getRow(i);
|
|
|
|
let id = row.id;
|
|
|
|
if (rowMap[id] !== undefined) {
|
|
|
|
Zotero.debug(`WARNING: _refreshRowMap(): ${this.type} row ${rowMap[id]} already found for item ${id} at ${i}`, 2);
|
|
|
|
Zotero.debug(new Error().stack, 2);
|
|
|
|
}
|
|
|
|
rowMap[id] = i;
|
|
|
|
}
|
|
|
|
this._rowMap = rowMap;
|
|
|
|
}
|
|
|
|
|
|
|
|
_onSelectionChange = () => {
|
|
|
|
if (!this._uninitialized) {
|
|
|
|
this.props.onSelectionChange && this.props.onSelectionChange(this.selection);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
_onSelectionChangeDebounced = Zotero.Utilities.debounce(this._onSelectionChange, 100)
|
|
|
|
|
|
|
|
handleTwistyMouseUp = (event, index) => {
|
|
|
|
this.toggleOpenState(index);
|
|
|
|
event.stopPropagation();
|
|
|
|
this.tree.focus();
|
|
|
|
}
|
|
|
|
|
|
|
|
// The caller has to ensure the tree is redrawn
|
|
|
|
ensureRowIsVisible(index) {
|
|
|
|
this.tree && this.tree.scrollToRow(index);
|
|
|
|
}
|
|
|
|
|
|
|
|
_updateHeight = () => {
|
|
|
|
this.forceUpdate(() => {
|
|
|
|
if (this.tree) {
|
|
|
|
this.tree.rerender();
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
updateHeight = Zotero.Utilities.debounce(this._updateHeight, 200);
|
|
|
|
|
|
|
|
updateFontSize() {
|
|
|
|
this.tree.updateFontSize();
|
|
|
|
}
|
|
|
|
|
|
|
|
setDropEffect(event, effect) {
|
|
|
|
// On Windows (in Fx26), Firefox uses 'move' for unmodified drags
|
|
|
|
// and 'copy'/'link' for drags with system-default modifier keys
|
|
|
|
// as long as the actions are allowed by the initial effectAllowed set
|
|
|
|
// in onDragStart, regardless of the effectAllowed or dropEffect set
|
|
|
|
// in onDragOver. It doesn't seem to be possible to use 'copy' for
|
|
|
|
// the default and 'move' for modified, as we need to in the collections
|
|
|
|
// tree. To prevent inaccurate cursor feedback, we set effectAllowed to
|
|
|
|
// 'copy' in onDragStart, which locks the cursor at 'copy'. ('none' still
|
|
|
|
// changes the cursor, but 'move'/'link' do not.) It'd be better to use
|
|
|
|
// the unadorned 'move', but we use 'copy' instead because with 'move' text
|
|
|
|
// can't be dragged to some external programs (e.g., Chrome, Notepad++),
|
|
|
|
// which seems worse than always showing 'copy' feedback.
|
|
|
|
//
|
|
|
|
// However, since effectAllowed is enforced, leaving it at 'copy'
|
|
|
|
// would prevent our modified 'move' in the collections tree from working,
|
|
|
|
// so we also have to set effectAllowed here (called from onDragOver) to
|
|
|
|
// the same action as the dropEffect. This allows the dropEffect setting
|
|
|
|
// (which we use in the tree's canDrop() and drop() to determine the desired
|
|
|
|
// action) to be changed, even if the cursor doesn't reflect the new setting.
|
|
|
|
if (Zotero.isWin || Zotero.isLinux) {
|
|
|
|
event.dataTransfer.effectAllowed = effect;
|
|
|
|
}
|
|
|
|
event.dataTransfer.dropEffect = effect;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
Zotero.Utilities.Internal.makeClassEventDispatcher(LibraryTree);
|
|
|
|
|
|
|
|
module.exports = LibraryTree;
|
|
|
|
|