c8261814fd
In many GNU/Linux setups, drawing attention when a notification arrives
causes the Signal window to steal focus immediately and interrupt the
user from what they were doing before the notification arrived. GNOME
Shell is the most prominent example of this behavior, but there are
likely other cases as well. Suddenly stealing focus on external events
like this can even pose a security problem in some cases, e.g. if the
user is in the middle of a typing a sudo password on one monitor while a
notification arrives and focuses Signal on another monitor. See #4452
for more information.
Disabling attention drawing entirely for Linux is also problematic
because some users rely on it as the sole indication of a new message,
as seen in #3582 and #3611.
Commit f790694559 improved the situation
by adding a hidden "--disable-flash-frame" command-line argument, but
this argument is undocumented and manually adding command-line arguments
to the application's .desktop file is not user-friendly.
This commit adds a settings option for whether to draw attention when a
new notification arrives to make it easy for all Linux users to obtain
the appropriate behavior without relying on an undocumented
command-line argument.
Fixes #4452.
114 lines
3.7 KiB
JavaScript
114 lines
3.7 KiB
JavaScript
/* global window */
|
|
|
|
const { ipcRenderer, remote } = require('electron');
|
|
|
|
const url = require('url');
|
|
const i18n = require('./js/modules/i18n');
|
|
|
|
const config = url.parse(window.location.toString(), true).query;
|
|
const { locale } = config;
|
|
const localeMessages = ipcRenderer.sendSync('locale-data');
|
|
|
|
const { nativeTheme } = remote.require('electron');
|
|
|
|
window.platform = process.platform;
|
|
window.theme = config.theme;
|
|
window.i18n = i18n.setup(locale, localeMessages);
|
|
window.appStartInitialSpellcheckSetting =
|
|
config.appStartInitialSpellcheckSetting === 'true';
|
|
|
|
function setSystemTheme() {
|
|
window.systemTheme = nativeTheme.shouldUseDarkColors ? 'dark' : 'light';
|
|
}
|
|
|
|
setSystemTheme();
|
|
|
|
window.subscribeToSystemThemeChange = fn => {
|
|
nativeTheme.on('updated', () => {
|
|
setSystemTheme();
|
|
fn();
|
|
});
|
|
};
|
|
|
|
window.getEnvironment = () => config.environment;
|
|
window.getVersion = () => config.version;
|
|
window.getAppInstance = () => config.appInstance;
|
|
|
|
// So far we're only using this for Signal.Types
|
|
const Signal = require('./js/modules/signal');
|
|
|
|
window.Signal = Signal.setup({
|
|
Attachments: null,
|
|
userDataPath: null,
|
|
getRegionCode: () => null,
|
|
});
|
|
|
|
window.closeSettings = () => ipcRenderer.send('close-settings');
|
|
|
|
window.getDeviceName = makeGetter('device-name');
|
|
|
|
window.getThemeSetting = makeGetter('theme-setting');
|
|
window.setThemeSetting = makeSetter('theme-setting');
|
|
window.getHideMenuBar = makeGetter('hide-menu-bar');
|
|
window.setHideMenuBar = makeSetter('hide-menu-bar');
|
|
|
|
window.getSpellCheck = makeGetter('spell-check');
|
|
window.setSpellCheck = makeSetter('spell-check');
|
|
|
|
window.getAlwaysRelayCalls = makeGetter('always-relay-calls');
|
|
window.setAlwaysRelayCalls = makeSetter('always-relay-calls');
|
|
|
|
window.getNotificationSetting = makeGetter('notification-setting');
|
|
window.setNotificationSetting = makeSetter('notification-setting');
|
|
window.getNotificationDrawAttention = makeGetter('notification-draw-attention');
|
|
window.setNotificationDrawAttention = makeSetter('notification-draw-attention');
|
|
window.getAudioNotification = makeGetter('audio-notification');
|
|
window.setAudioNotification = makeSetter('audio-notification');
|
|
window.getCallRingtoneNotification = makeGetter('call-ringtone-notification');
|
|
window.setCallRingtoneNotification = makeSetter('call-ringtone-notification');
|
|
window.getCallSystemNotification = makeGetter('call-system-notification');
|
|
window.setCallSystemNotification = makeSetter('call-system-notification');
|
|
window.getIncomingCallNotification = makeGetter('incoming-call-notification');
|
|
window.setIncomingCallNotification = makeSetter('incoming-call-notification');
|
|
|
|
window.getMediaPermissions = makeGetter('media-permissions');
|
|
window.setMediaPermissions = makeSetter('media-permissions');
|
|
window.getMediaCameraPermissions = makeGetter('media-camera-permissions');
|
|
window.setMediaCameraPermissions = makeSetter('media-camera-permissions');
|
|
|
|
window.isPrimary = makeGetter('is-primary');
|
|
window.makeSyncRequest = makeGetter('sync-request');
|
|
window.getLastSyncTime = makeGetter('sync-time');
|
|
window.setLastSyncTime = makeSetter('sync-time');
|
|
|
|
window.deleteAllData = () => ipcRenderer.send('delete-all-data');
|
|
|
|
function makeGetter(name) {
|
|
return () =>
|
|
new Promise((resolve, reject) => {
|
|
ipcRenderer.once(`get-success-${name}`, (event, error, value) => {
|
|
if (error) {
|
|
return reject(error);
|
|
}
|
|
|
|
return resolve(value);
|
|
});
|
|
ipcRenderer.send(`get-${name}`);
|
|
});
|
|
}
|
|
|
|
function makeSetter(name) {
|
|
return value =>
|
|
new Promise((resolve, reject) => {
|
|
ipcRenderer.once(`set-success-${name}`, (event, error) => {
|
|
if (error) {
|
|
return reject(error);
|
|
}
|
|
|
|
return resolve();
|
|
});
|
|
ipcRenderer.send(`set-${name}`, value);
|
|
});
|
|
}
|
|
|
|
require('./js/logging');
|