Commit graph

2589 commits

Author SHA1 Message Date
lilia
3dbb21c53c Fix being re-added to a group you previously left
Negate the flag marking the group as left. Fixes #1207.

// FREEBIE
2017-05-30 10:51:07 -07:00
Scott Nonnenberg
13a91eece8 MessageListView.measureScrollPosition: reuse variables 2017-05-30 10:44:00 -07:00
Scott Nonnenberg
c5530b7235 Increase wiggle room to 30 px, which should ensure text cut off
FREEBIE
2017-05-30 10:44:00 -07:00
Scott Nonnenberg
84397a2ef4 20px at bottom of conversation considered 'at the bottom'
So users who are 'close enough' at the bottom of the conversation won't
get marooned in history.

FREEBIE
2017-05-30 10:44:00 -07:00
lilia
cc4d2993d1 Remove out of date test
This test is out of date with respect to the latest signed key rotation rules
implemented in b92dd45 and 536dd7b. Previously we would only keep the last two
signed keys, but now we keep at least three as well as requiring a minimum
retention period. As a result, this test should be failing, but we haven't
noticed because it's not using the `done` parameter to signal its asynchronous
nature.

// FREEBIE
2017-05-29 22:28:28 -07:00
Scott Nonnenberg
09791ab7d9 Make last seen indicator more stable, with less forced removal
FREEBIE
2017-05-26 17:26:35 -07:00
Scott Nonnenberg
c3dc9732ef Fix: Don't scroll to last seen indicator on focus
FREEBIE
2017-05-26 17:26:35 -07:00
Scott Nonnenberg
10c2874d19 Fix race condition: Pull from database after add to conversation
Also add some console logs to help us determine whether this ever
happens to people in the wild.

FREEBIE
2017-05-26 16:02:14 -07:00
lilia
e9152d9d27 Bump version
// FREEBIE
2017-05-25 16:53:09 -07:00
lilia
54d14dde31 Update translations
// FREEBIE
2017-05-25 16:52:22 -07:00
Scott Nonnenberg
10a6dc8b6f Update manual test script to reflect scroll/last-seen updates
FREEBIE
2017-05-25 16:41:21 -07:00
Scott Nonnenberg
9de384f3b8 Reset last seen indicator timing on focus of window
FREEBIE
2017-05-25 16:41:21 -07:00
Scott Nonnenberg
01918049b4 Keep last seen indicator around for five seconds
Helps calm the user experience a little more, makes it easier to
understand what's happening when messages are coming in quickly.

FREEBIE
2017-05-25 16:41:21 -07:00
Scott Nonnenberg
4e9e811d12 Last seen indicator: Keep scroll position when window loses focus
FREEBIE
2017-05-25 16:41:21 -07:00
Scott Nonnenberg
3beecce94e fetchConversation: Minimize scans across loaded messages
FREEBIE
2017-05-25 16:30:30 -07:00
Scott Nonnenberg
d5d1d58cc2 Exclude Backbone-sourced method from jscs checks
FREEBIE
2017-05-25 16:30:30 -07:00
Scott Nonnenberg
3ceb3a049e Override Message.fetch to ensure that db data overrides local
FREEBIE
2017-05-25 16:30:30 -07:00
Scott Nonnenberg
2c81539042 A guard to prevent infinite loops in fetching of conversation
FREEBIE
2017-05-25 16:30:30 -07:00
r-clancy
66b19d5cf7 Add support for opening the inbox via a shortcut - fixes #1134. 2017-05-24 10:51:38 -07:00
Scott Nonnenberg
d294cc96a5 A few tweaks to safety number-related UI
* Show a pointer cursor on safety number change notification
* Add 'click to verify' to the text shown there
* Add ':' to the text shown on the safety number screen
* Limit the width of the safety number box, to force 3x4 layout
* Center the safety number box

FREEBIE
2017-05-23 15:50:22 -07:00
Ivan Markin
931441a057 Fix duplicate x icon (cancel) on active search field.
Fixes #1136.
// FREEBIE
2017-05-23 15:46:28 -07:00
Scott Nonnenberg
fdf04f6229 Ensure that we never show last seen indicator if count is zero
FREEBIE
2017-05-23 15:41:05 -07:00
Scott Nonnenberg
be981d6f48 Update manual test script after changes to last seen indicator
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
1839efd535 Move margin-top back to inner last seen indicator element
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
e023c58883 Update last seen indicator even if window doesn't have focus
FREEBIE
2017-05-23 11:08:23 -07:00
lilia
72019eb79c Reuse a variable
FREEBIE
2017-05-23 11:08:23 -07:00
lilia
176339ffe6 Add log to see if we ever fetch while fetching
// FREEBIE
2017-05-23 11:08:23 -07:00
lilia
16f3717824 Move refresh prekeys out of SignalProtocolStore
Use an event/listener instead

// FREEBIE
2017-05-23 11:08:23 -07:00
lilia
681418cf6b Restyle last seen indicator
Add horizontal line behind text.

// FREEBIE
2017-05-23 11:08:23 -07:00
lilia
4921ef1b9d Tweak scroll to bottom bottom color
And add drop shadow

// FREEBIE
2017-05-23 11:08:23 -07:00
lilia
017bb56cca Fix some corner casese with last seen indicator
* Remove increment behavior
* Dismiss when new messages arrive but the window is focused
* Update the indicator when window becomes focused.

// FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
bb468e7b01 Wait for scroll before deciding whether to add scroll down button
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
ae7044fd30 Add recursive fetch scenario to manual test script
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
30b7bf23db Recursively fetch messages until we've loaded all unread
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
533ec52d0c test/manual.txt: add scenarios for new scroll down button
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
8b4402e8a5 Only show scroll down button if we're not at bottom of convo
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
4c7bfbe9ff Scroll down button: when scrolled up, or new non-visible message
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
13322c7071 test/fixtures.js: Cleanup - data at top, images/setup at bottom
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
86c866738f Introduce unread message to fixtures, further interactivity fixes
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
318162e74a LastSeenIndicatorView: programmatic tests, tweak to manual tests
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
1608acf449 Add new test/manual.txt with scenarios for last-seen, scrolling
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
33cdc6ae71 test/index.html: Comments to help in turning off code coverage
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
0a5960e091 Restore interactivity to InboxViews hosted on test page
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
3cfac58d78 Eliminate all console errors during test run
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
f6c62e4822 Android: Make last seen indicator margin consistent top/bottom
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
3e01d78c89 MessageListView remove unused reset-scroll event
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
73f2a4a0fb Simplify MessageListView.resetScrollPosition: no translation math
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
bfdb8254a4 Scroll on new message only if we were already at bottom
FREEBIE
2017-05-23 11:08:23 -07:00
Scott Nonnenberg
fed26c36ca Add new Last Seen Indicator with unread count, scroll to it
This is to ensure that when there are a lot of unread messages, the user
is given the chance to see all of them by being scrolled to the oldest
new message.

When a new message comes in, the indicator will be incremented.

When the user sends a message or switches away from the conversation,
the last seen indicator will be removed.

FREEBIE
2017-05-23 11:08:23 -07:00
lilia
bec69826ae Add descriptions to i18n messages about network status
A transifx translator requested some clarity around one of these strings, so
I've added brief descriptions for each of them.

// FREEBIE
2017-05-22 12:16:25 -07:00