Commit graph

235 commits

Author SHA1 Message Date
Daniel Gasienica
aa7665e497 Run Prettier on all source files 2018-04-30 16:52:43 -04:00
Daniel Gasienica
1bf3ab630c Add eslint-config-prettier 2018-04-30 16:52:43 -04:00
Scott Nonnenberg
b9b85a0030
v1.9.0-beta.1
Send quoted replies via hover menu on message (#2284, #2292)

Fixed: Linking a new iOS device would not initially show iOS theme (#2284)

Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)

Dev:
  - Fix beta install instructions in readme for debian-based linux (#2262)
  - Media Gallery: Phase 1 - currently disabled (#2236)
2018-04-25 13:01:54 -07:00
Daniel Gasienica
5ec8b1c6e1 Add @types/jquery 2018-04-25 15:24:51 -04:00
Daniel Gasienica
dea56c0008 Autoformat TSX files 2018-04-25 15:24:51 -04:00
Daniel Gasienica
2fae89f0e8 Add trailing commas to autoformatted code 2018-04-25 15:24:51 -04:00
Daniel Gasienica
347fc8287a Add yarn format to autoformat code
Uses Prettier under the hood. Requires opt-in via `@prettier` pragma:
https://prettier.io/docs/en/options.html#require-pragma
2018-04-25 15:24:51 -04:00
Daniel Gasienica
56a5006392 Remove duplicate @types/lodash dependency 2018-04-25 15:24:51 -04:00
Daniel Gasienica
3a8c3ccdab Add prettier 2018-04-25 15:24:51 -04:00
Daniel Gasienica
8ef04cb1fd Move @types/* dependencies to devDependencies 2018-04-25 15:24:51 -04:00
Daniel Gasienica
10bede85c9 Add filesize dependency 2018-04-25 15:24:50 -04:00
Daniel Gasienica
9533c09707 Add @types/lodash 2018-04-25 15:24:50 -04:00
Scott Nonnenberg
a7d44d3344
Backup and end-to-end test! 2018-04-20 15:24:04 -07:00
Scott Nonnenberg
3dbc550db2
v1.8.0-beta.1
Receive quoted replies (#2244)

iOS theme: one bubble for both attachment and message contents (#2244)

Improve URL Auto-Linking In Messages (#2240)

Redact More Variants Of Paths In Stack Traces (#2229)

Fixed: Conversation message preview would sometimes continue to show after message disappeared (1206b3c448)

Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
2018-04-16 13:14:18 -07:00
Scott Nonnenberg
21bf02c94d
Fixed examples in Quote.md, rough Android visuals 2018-04-13 18:05:44 -07:00
Daniel Gasienica
560cc4e149 Set dynamic parameter last 2018-04-11 19:46:23 -04:00
Daniel Gasienica
9d159da79c Add Microsoft contributed TSlint rules: tslint-microsoft-contrib 2018-04-11 19:45:31 -04:00
Daniel Gasienica
55fc21505e Rename ts/test to ts/styleguide 2018-04-11 16:36:42 -04:00
Daniel Gasienica
99dbdc3506 Include compiled TypeScript JavaScript files in build 2018-04-11 16:36:42 -04:00
Daniel Gasienica
d6436de3bd Organize npm scripts
Combine `yarn grunt jshint` and `yarn grunt jscs` into `yarn grunt lint`.
2018-04-11 16:36:42 -04:00
Daniel Gasienica
6f4d0e1449 Use project for TSLint 2018-04-11 16:36:42 -04:00
Daniel Gasienica
15d221ae0e Simplify testing and linting
Separate linting from testing as follows:

- `yarn jscs`: Run JSCS.
- `yarn jshint`: Run JSHint.
- `yarn lint`: Run all linters, i.e. ESLint, TSLint, JSHint, and JSHint.

- `yarn test-node`: Run Mocha tests in Node.js environment.
- `yarn test-electron`: Run tests in Electron environment via Grunt.
- `yarn test`: Run all tests.

CI
- Align Travis and AppVeyor scripts as much as possible.
- Run linting before tests to fail fast.
- Run Node.js (headless and fast) tests first.
- Run Electron tests last (Travis seems to require custom setup in `travis.sh`).
2018-04-11 16:36:42 -04:00
Daniel Gasienica
d6b40a3e94 Explicitly point to TSLint configuration
AppVeyor seems to ignore our configuration.
2018-04-11 16:36:42 -04:00
Daniel Gasienica
9d41b86162 Remove escaping from linkText
We leverage jQuery’s HTML escaping in `$.html(…)`.
2018-04-11 16:36:42 -04:00
Daniel Gasienica
d9381c543e Add linkify-it dependency 2018-04-11 16:36:42 -04:00
Daniel Gasienica
7d4ef9315b Add yarn test-ts 2018-04-11 16:36:42 -04:00
Daniel Gasienica
6f8dee402d Add @types/mocha 2018-04-11 16:36:42 -04:00
Daniel Gasienica
7ac4bee959 Add @types/chai 2018-04-11 16:36:42 -04:00
Daniel Gasienica
78ba4eddc1 Add @types/lodash 2018-04-11 16:36:42 -04:00
Daniel Gasienica
f5641fe6d6 Add link-text dependency
It only has the minimum required dependencies:
- `linkify-it`: Best-in-class link detection library with support for
                Unicode/IDN.
- `escape-html`: Standalone dependency for escaping HTML.
- `uc.micro`: Standalone dependency of Unicode data files.
2018-04-11 16:36:42 -04:00
Scott Nonnenberg
c6c3b65bbc
Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219)
Quite a bit of change here.

First, the basics:

- New dependencies were added: react, typescript, tslint, and react-styleguidist
- A new npm script: transpile. It uses typescript to process .tsx files in js/react, putting .js files next to the original file. It's part of the watch functionality of grunt dev as well as the default task run with just grunt (used to build the app prior to release). A lighter-weight to get watch behavior when just working on React components is to run yarn transpile --watch.
- yarn run clean-transpile will remove generated .js files


Style guide via react-styleguidist. Example site: https://react-styleguidist.js.org/examples/basic/

- Start with yarn styleguide
- Component.md files right next to the .tsx file
- jsdoc-style comments are picked up and added to the generated part of the styleguide - the overall summary and a table listing methods and properties of the component
- It has hot-reloading!
- It uses webpack, which means that our app now pulls in webpack though we don't use it to generate anything for the production app.
- I did a bunch of work to enable the use of Backbone views in this context, which will allow us to move smoothly from the old world to the new. First, add all the permutations in the old way, and then slowly start to re-render those same views with React.

A bit of dependency cleanup to enable use in React components:

- moment was moved from our Bower dependencies to our npm dependencies, so it can be used in React components not running in a browser window.
- i18n was moved into the new commonjs format, so it can be used in React components even if window is not available.

Lastly, a bit of Gruntfile cleanup:

- Removal of Chrome App-era modifications of background.js
- Make jshint/jscs watch more targeted, since more and more we'll be using other tools
2018-04-06 08:13:00 -07:00
Scott Nonnenberg
23537546fe
Big refactor: ts/ directory for all typescript, including react
Split out test-specific and general utility react components too.

And moved our test/legacy* files for the Style Guide into a styleguide/
subdirectory of test/.

I think we'll be able to live in this directory structure for a while.
2018-04-05 15:30:40 -07:00
Scott Nonnenberg
1052341d79
Fix tslint errors and add tslint to CI task in package.json 2018-04-05 08:37:04 -07:00
Scott Nonnenberg
be91a89d68
Parse theme from querystring, put on util. Moment from require()
We also fully set up i18n and put it on util as well as making
it available on windows.i18n for Backbone views.
2018-04-05 08:31:43 -07:00
Scott Nonnenberg
ef6a0c1162
v1.7.0-beta.3
Update to electron 1.8.4 (#2186)

Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129)

Save attachments to disk when importing Chrome app export (#2212)

Fixed: Read receipts setting would not be synchronized along with re-link (#2218)

Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks
@colefranz! (#2032)

Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191)

Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167)

Dev:
  - Relax Node.js version requirements (#2203)
  - Fix a few typos in documentation - thanks @Vinnl (#2171)
  - Update issue template to mention that translation should be via Transifex (#2157)
2018-04-04 17:13:23 -07:00
Scott Nonnenberg
1326b26585
Full styleguide now available via yarn styleguide
Due to a number of hacks, the style guide can be used to show Backbone
views. This will allow a smooth path from the old way of doing things to
the new.
2018-04-04 16:08:38 -07:00
Scott Nonnenberg
893fb1cb9e
Introduce React/TypeScript/TSLint into app for new UI components
npm run transpile
  Works on files under js/react/
  Outputs files right next to the .tsx file

This is part of our `grunt dev` task, as well as the default grunt task,
which does everything else necessary to get a raw git checkout ready to
run.
2018-04-04 16:08:27 -07:00
Scott Nonnenberg
1ad2b080c8
Move moment from bower deps to npm deps 2018-04-04 16:00:38 -07:00
Daniel Gasienica
29832c445a Add @sindresorhus/is dependency
This will allow us to do runtime and, once we have TypeScript support,
compile-time type checks.
2018-04-04 17:40:19 -04:00
Daniel Gasienica
7d0871ee0e Run tests using yarn instead of npm 2018-04-03 11:45:11 -04:00
AJ Jordan
81ac6a9031
Don't lock the Node version so strictly
This is particularly problematic because Yarn apparently
errors (not warns) if the engine doesn't match.
2018-04-02 00:42:58 -04:00
Scott Nonnenberg
4e6d1e128f
Update to electron 1.8.4 (#2186) 2018-03-26 14:39:55 -07:00
Daniel Gasienica
7eaa6ef2f7 Remove string-to-arraybuffer dependency
The function is simple enough to inline and this allows us to reduce our
dependencies surface area.
2018-03-26 16:38:34 -04:00
Daniel Gasienica
232e906650 Remove tmp as dev dependency 2018-03-26 16:38:34 -04:00
Daniel Gasienica
19a70ad8b8 Add to-arraybuffer dependency
Used for converting Node.js buffers to `ArrayBuffer`.
2018-03-26 16:38:34 -04:00
Daniel Gasienica
0fc2868f0e Remove tempy dependency
We already use `tmp`.
2018-03-26 16:38:34 -04:00
Daniel Gasienica
14f58281bc Add string-to-array-buffer as dev dependency
Used for testing attachment data migration.
2018-03-26 16:38:34 -04:00
Daniel Gasienica
925ddbd7db Add tempy as dev dependency
Useful for creating random temporary directories for testing.
2018-03-26 16:38:34 -04:00
Daniel Gasienica
14422652c6 Add fs-extra as direct dependency
Allows us to use `fs` with promises. Turns out it’s already a
transitive dependency.
2018-03-26 16:38:34 -04:00
Scott Nonnenberg
0d105fc190
1.7.0-beta.2
Fixed: White block at bottom of conversation panel in iOS theme
(#2144 and #2153)

Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(1c6d91b59c)

Dev:
  - Introduce IndexedDB index on `messages` store tracking
    `schemaVersion` (#2128)
  - Preparation for encrypted backups
    (cea42bde7d)
  - Updates to structure of exported data - messages.zip, flat list of
    attachments (6d8f4b7b6e)
2018-03-20 14:05:16 -07:00