Commit graph

5365 commits

Author SHA1 Message Date
Danny Lin
c8261814fd
Add setting to toggle notification attention drawing (#4457)
In many GNU/Linux setups, drawing attention when a notification arrives
causes the Signal window to steal focus immediately and interrupt the
user from what they were doing before the notification arrived. GNOME
Shell is the most prominent example of this behavior, but there are
likely other cases as well. Suddenly stealing focus on external events
like this can even pose a security problem in some cases, e.g. if the
user is in the middle of a typing a sudo password on one monitor while a
notification arrives and focuses Signal on another monitor. See #4452
for more information.

Disabling attention drawing entirely for Linux is also problematic
because some users rely on it as the sole indication of a new message,
as seen in #3582 and #3611.

Commit f790694559 improved the situation
by adding a hidden "--disable-flash-frame" command-line argument, but
this argument is undocumented and manually adding command-line arguments
to the application's .desktop file is not user-friendly.

This commit adds a settings option for whether to draw attention when a
new notification arrives to make it easy for all Linux users to obtain
the appropriate behavior without relying on an undocumented
command-line argument.

Fixes #4452.
2020-08-24 14:45:31 -07:00
u32i64
0c9e7ced60
Fix some typos in messages.json (#4447) 2020-08-14 10:01:51 -07:00
Scott Nonnenberg
724a627dd3 v1.35.1-beta.1 2020-08-13 16:44:21 -07:00
Scott Nonnenberg
22e7c9c56f Update strings 2020-08-13 16:26:29 -07:00
Scott Nonnenberg
2db1569fbd
Fix conversation last activity calculation 2020-08-13 17:47:50 -05:00
Evan Hahn
aa43f322b3
Remove scrollbar from author title in quotes 2020-08-13 15:21:05 -07:00
Josh Perez
02607edfff
Fix selectedReaction which is now always undefined 2020-08-13 15:19:04 -07:00
Scott Nonnenberg
3615096497
Fix contact name rendering on call screen 2020-08-13 18:02:28 -04:00
Chris Svenningsen
d3d3c41f94
Convert <Avatar /> component to Storybook
Co-authored-by: Chris Svenningsen <chris@carbonfive.com>
Co-authored-by: Sidney Keese <me@sidke.com>
2020-08-13 13:53:45 -07:00
Josh Perez
4169c120fc
Ensure all native modules exist outside of asar 2020-08-12 18:30:47 -07:00
Scott Nonnenberg
eb44e2fc6a
Calling: Show call event summaries in left pane 2020-08-12 19:52:34 -04:00
Josh Perez
474d1694ed
Error out in CI if there is a diff 2020-08-12 15:47:46 -07:00
Evan Hahn
a8090d8c66
A few CSS fixes for message bubbles 2020-08-12 15:47:20 -07:00
Scott Nonnenberg
c369363e10
Storage Service: Don't create groups from incoming v1 records 2020-08-11 21:07:55 -04:00
Scott Nonnenberg
67058e27bb
Safely generate cached conversation props on startup 2020-08-11 19:15:06 -04:00
Evan Hahn
b32445cd20
Upgrade node-fetch to latest version, v2.6.0 2020-08-11 14:23:37 -07:00
Evan Hahn
4df52c5349
Add 9 dangerous extensions and ignore trailing dot 2020-08-10 13:13:06 -07:00
Scott Nonnenberg
0fee1f9935
WebAPI.getProfileURL: Use profileKeyVersion by itself if we have it 2020-08-10 15:39:06 -04:00
Josh Perez
6a68b37c83
New message state: Partially sent 2020-08-06 18:22:52 -07:00
Scott Nonnenberg
81cb7730a5
Message Requests improvements 2020-08-06 20:50:54 -04:00
Scott Nonnenberg
b63291507a
Sync messages: Additional debugging info, consistent ids 2020-08-06 13:28:56 -04:00
Jim Gustafson
1227a51c99
Update to RingRTC v2.4.2 2020-08-05 14:35:42 -07:00
Scott Nonnenberg
57308d3104
Fixes several bugs 2020-08-04 21:13:19 -04:00
Scott Nonnenberg
7eabdffcd0
Update message.isEmpty() and .isNormalBubble() with recent additions 2020-07-30 20:10:54 -04:00
Jim Gustafson
7eb5c922a7 Update to RingRTC v2.4.1 2020-07-30 13:27:44 -07:00
Scott Nonnenberg
d75eee015f Show notifications when a user's profile name changes 2020-07-30 13:27:44 -07:00
Jim Gustafson
2f015863ca Upgrade to RingRTC v2.4.0 2020-07-30 13:27:44 -07:00
Scott Nonnenberg
7ef5dc6401 AvatarPopup: Show profile name if we have it 2020-07-30 13:27:44 -07:00
Scott Nonnenberg
5a79ed1c60 combineContacts: Don't clear conversations to reset lookups 2020-07-30 13:27:44 -07:00
Scott Nonnenberg
bab59ba2a1 Force social graph to pull down updates after beta.11 install 2020-07-30 13:27:44 -07:00
Scott Nonnenberg
d07b8e82b2 First-class profile name rendering 2020-07-30 13:27:41 -07:00
Jim Gustafson
632cd0e87e Drop incoming calls if conversation is not 'accepted' 2020-07-30 13:18:36 -07:00
Josh Perez
0f8a60acc3 Integrate message requests with storage service 2020-07-30 13:18:34 -07:00
Josh Perez
9433a1de99 Don't reset panel on close of recent media pane 2020-07-30 13:17:47 -07:00
Scott Nonnenberg
901179440f Merge contacts when we discover split or duplicated contacts 2020-07-30 13:17:45 -07:00
Josh Perez
68e432188b Add unknown fields support to Protobuf.js 2020-07-30 13:10:05 -07:00
Peter Thatcher
c6d5607b8c Fix incoming call ringtone by awaiting the playout 2020-07-30 13:10:05 -07:00
Josh Perez
126b828f46 Storage Service: Update local manifest version when it changes 2020-07-30 13:10:05 -07:00
Josh Perez
8502d23576 Social Graph: read-only state sync with primary device 2020-07-30 13:10:05 -07:00
Jim Gustafson
12745a2c79 Update to RingRTC v2.3.1 2020-07-30 13:10:05 -07:00
Scott Nonnenberg
7f71046f93 Restore ability to get to safety number screen from member list 2020-07-30 13:10:05 -07:00
Josh Perez
5b83485c89 Update safety number change warning dialog 2020-07-30 13:10:05 -07:00
Jim Gustafson
e87a0103cc Use message age to expire old incoming calls 2020-07-30 13:10:05 -07:00
Jim Gustafson
870a0d2b65 Support RingRTC message sending queue 2020-07-30 13:10:05 -07:00
Ken Powers
bf04c9114e Harden UUID-handling code paths 2020-07-30 13:10:03 -07:00
Peter Thatcher
d3a27a6442 Calling support 2020-07-30 13:08:47 -07:00
Ken Powers
83574eb067 Message Requests 2020-07-30 13:08:44 -07:00
Scott Nonnenberg
4d4b7a26a5 v1.34.5-beta.1 2020-07-30 11:15:03 -07:00
Josh Perez
e5aaf9f501 Remove unneeded entitlements
Thanks to Csaba Fitzl (@theevilbit) of Offensive Security for bringing
this to our attention.
2020-07-29 17:15:12 -07:00
Scott Nonnenberg
1518b159d3 Only use membersE164 field in GroupV1 messages 2020-07-27 14:49:37 -07:00