* Change systemPreferences.isDarkMode() to nativeTheme.shouldUseDarkColors
* Remove vibrancy parameter to BrowserWindow
* Update curve25519-n; removes context-aware deprecation warning
* Set app.allowRendererProcessReuse = true to remove warning
* Move from deprecated setters to direct property set
* Serialized sender certificates: Store less, store plain object
* isMenuBarAutoHide -> autoHideMenuBar
* UUID: Fix sealed sender indicator on message details screen
* Data._cleanData: Remove function keys, handle null in array
Also:
- run _cleanData when saving attachment download jobs
- remove job from jobs table when the send itself throws error
* _cleanData: Don't dig into strings, booleans, or numbers
* getPropsForMessageDetail: Make it clear what we're reducing
Co-authored-by: Ken Powers <ken@signal.org>
* Introduce normalize-path wherever we use fastGlob
* CI: Update yarn version; install yarn via npm on windows
* Add more logging to Grunt file spectron usage
* Lock core.js to what it was resolving to before: 2.4.1
* test/index.html: Remove nonexistent test file
* test/index.html: Remove missing registration.js
* preload.js: Introduce client-side logging for load failures
* Gruntfile: Introduce better debuggability if prod test fails
* Reintroduce glob for searches inside asar
* writeToDownloads: Add missing await
* Remove window.isFocused() - not used anywhere!
* Update typescript, p-queue, make necessary changes to fix build
* Slow down sender certificate retries with no existing cert
* Slow down signed prekey refreshes when unlinked - 5s -> 5m
* Update protobufjs to 4.1.2
* Decrypt given and family names from profile name string
* Handle both given and family name from decrypted profile name
* Ensure we properly handle profiles with no family name
* If focus was set to document.body during archive, focus left pane
* Shortcut Guide: Add space between text and shortcut highlight
* Ensure that draft attachment can be closed with click on X button
* Move to keyDown event for user idle checking
* Additional resiliency around avatars; check for them on on-disk
* Increase timeouts to preserve websocket connection
* On startup, be resilient to malformed JSON in log files
* Don't crash if shell.openExternal returns an error
* Whenever we request a contact/group sync, also request block list
* Avatar popup: Ensure styling is mouse- and keyboard-appropriate
* MainHeader: Create popperRoot on demand, not on mount
* CompositionInput: Disable default Ctrl-/ shortcut
* Update libphonenumber
* Adds right-click listener
For urls and text selections
* Fixes build-release on windows
Should still be bash compatible too
* Update context menu line
Responding to feedback from @JaredPotter
* Update spectron to fix linux CI runs
* Point test-release grunt task at release folder
* Ensure that build folders of socks/smart-buffer are in build
* AppVeyor: windows build output folder is now release
* Travis: Force build output to release directory
Quite a few other fixes, including:
- Sending to contact with no avatar yet (not synced from mobile)
- Left pane doesn't update quickly or at all on new message
- Left pane doesn't show sent or error status
Also:
- Contributing.md: Ensure set of linux dev dependencies is complete
Also:
- New schema version 8 with video/image thumbnails, screenshots, sizes
- Upgrade messages not at current schema version when loading messages
to show in conversation
- New MessageDetail react component
- New ConversationHeader react component
UI now in separate renderer:
- the permissions popup
- settings dialog
- debug log dialog
- about window
Couple bug fixes:
- About Window: Fix 'escape' to close window
- Remove outdated dist/copy tasks from Gruntfile
Eslintified settings_view.js
Biggest changes forced by this: alt tags for all images, resulting in
new strings added to messages.json, and a new i18n paramter/prop added
in a plot of places.
Another change of note is that there are two new tslint.json files under
ts/test and ts/styleguide to relax our rules a bit there. This required
a change to our package.json script, as manually specifying the config
file there made it ignore our tslint.json files in subdirectories
* Remove extra parenthesis causing warnings on latest chromium
* Update to electron 2.0.1
* Move all @types dependencies to devDependencies
* Update electron-builder/electron-updater
* Update to Node.js 8.9.3 to match Electron 2.0.1
Notification Improvements (#2364)
- Fixed: The change for production didn't full make it into v1.11.0-beta.1 - this change restores the code which removes the old notification when we add a new one
- Fixed: Notifications could be orphaned in notification center if they were added/removed quickly
- Fixed: Notifications weren't removed properly when read on a linked device
Dev: Better logging when we receive a read sync from a linked device (#2364)
Feature: Receive contact (#2349, #2359)
Fixed: Sometimes clicks on quoted message wouldn't work (#2350)
Fixed: In dark theme, it was hard to see a message's triple-dot menu on hover - thanks @PunkChameleon (#2334)
Fixed: Unsupported image and video types were missing from media pane (#2351)
Fixed: On small screens, the media lightbox view would show media off-screen (#2351)
Notification improvements
- Remove all on remote read, on focus, on exit
- Show multi-message notifications like '5 new messages'
Media Gallery: A number of small visual fixes (#2351)
Emoji pane: Can now dismiss it by pressing escape key - thanks @tommypacker (#2354, #2357)
Update translations (#2328, #2352)
Dev:
- Windows 7: Use Electron-native notifications (#2338, #2330)
- Improve Logging For Disappearing Messages (#2332)
- Prettier: Continue expanding its coverage of app (#2339, #2324)
- Document Translations Setup + Remove Unused Strings (#2329)
- Make Protocol Buffers available to commonjs code (#2347)
This does not work with `ArrayBuffer` out of the box and will need to be
investigated and tested more before switching.
Some APIs also seemed to have changed:
- Before (OOP): `new textsecure.protobuf.WebSocketMessage(…).encode();`
- After (functional):
```
textsecure.protobuf.WebSocketMessage.encode(
new textsecure.protobuf.WebSocketMessage(…)
);
```
This reverts commit d758119d9de4f99742ea941e86180b1d600c2f22.
We missed a couple directories with previous attempts to turn this on
globally: app/ and libtextsecure/
Not to mention files in places we didn't expect: ts files that weren't
in the ts directory!
This turns prettier on for every file we care about (js, ts, tsx, md)
everywhere in the project but for a few key parts.
Linux: deb (dropped zip)
Mac: zip (dropped dmg)
Windows: exe (dropped zip)
We can always re-add if people are relying on these things. But our
download links all point to these assets, so we'll generate and upload
only these for now.
Media Gallery showing all attachments in a given conversation (#2291, previous: #2236)
Quotes:
- Show 'You' in Android theme instead of your own contact name (#2312)
- Show thumbnails for quotes of messages with video attachments (#2293)
Video attachments: show first frame preview in composition area (#2293)
Increase speed of migration to move attachments to disk from database (#2314)
Dev:
- Add comments clarifying our mechanisms for stripping EXIF info (#2313)
- Move to prettierjs to format our code (#2303)
- Fix break in styleguide; make filesize/Signal.Util.GoogleChrome available (#2302)
- Remove duplicate entry from .gitignore (#2271)
Send quoted replies via hover menu on message (#2284, #2292)
Fixed: Linking a new iOS device would not initially show iOS theme (#2284)
Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)
Dev:
- Fix beta install instructions in readme for debian-based linux (#2262)
- Media Gallery: Phase 1 - currently disabled (#2236)
Receive quoted replies (#2244)
iOS theme: one bubble for both attachment and message contents (#2244)
Improve URL Auto-Linking In Messages (#2240)
Redact More Variants Of Paths In Stack Traces (#2229)
Fixed: Conversation message preview would sometimes continue to show after message disappeared (1206b3c448)
Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
Separate linting from testing as follows:
- `yarn jscs`: Run JSCS.
- `yarn jshint`: Run JSHint.
- `yarn lint`: Run all linters, i.e. ESLint, TSLint, JSHint, and JSHint.
- `yarn test-node`: Run Mocha tests in Node.js environment.
- `yarn test-electron`: Run tests in Electron environment via Grunt.
- `yarn test`: Run all tests.
CI
- Align Travis and AppVeyor scripts as much as possible.
- Run linting before tests to fail fast.
- Run Node.js (headless and fast) tests first.
- Run Electron tests last (Travis seems to require custom setup in `travis.sh`).
It only has the minimum required dependencies:
- `linkify-it`: Best-in-class link detection library with support for
Unicode/IDN.
- `escape-html`: Standalone dependency for escaping HTML.
- `uc.micro`: Standalone dependency of Unicode data files.
Quite a bit of change here.
First, the basics:
- New dependencies were added: react, typescript, tslint, and react-styleguidist
- A new npm script: transpile. It uses typescript to process .tsx files in js/react, putting .js files next to the original file. It's part of the watch functionality of grunt dev as well as the default task run with just grunt (used to build the app prior to release). A lighter-weight to get watch behavior when just working on React components is to run yarn transpile --watch.
- yarn run clean-transpile will remove generated .js files
Style guide via react-styleguidist. Example site: https://react-styleguidist.js.org/examples/basic/
- Start with yarn styleguide
- Component.md files right next to the .tsx file
- jsdoc-style comments are picked up and added to the generated part of the styleguide - the overall summary and a table listing methods and properties of the component
- It has hot-reloading!
- It uses webpack, which means that our app now pulls in webpack though we don't use it to generate anything for the production app.
- I did a bunch of work to enable the use of Backbone views in this context, which will allow us to move smoothly from the old world to the new. First, add all the permutations in the old way, and then slowly start to re-render those same views with React.
A bit of dependency cleanup to enable use in React components:
- moment was moved from our Bower dependencies to our npm dependencies, so it can be used in React components not running in a browser window.
- i18n was moved into the new commonjs format, so it can be used in React components even if window is not available.
Lastly, a bit of Gruntfile cleanup:
- Removal of Chrome App-era modifications of background.js
- Make jshint/jscs watch more targeted, since more and more we'll be using other tools
Split out test-specific and general utility react components too.
And moved our test/legacy* files for the Style Guide into a styleguide/
subdirectory of test/.
I think we'll be able to live in this directory structure for a while.
Update to electron 1.8.4 (#2186)
Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129)
Save attachments to disk when importing Chrome app export (#2212)
Fixed: Read receipts setting would not be synchronized along with re-link (#2218)
Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks
@colefranz! (#2032)
Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191)
Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167)
Dev:
- Relax Node.js version requirements (#2203)
- Fix a few typos in documentation - thanks @Vinnl (#2171)
- Update issue template to mention that translation should be via Transifex (#2157)
Due to a number of hacks, the style guide can be used to show Backbone
views. This will allow a smooth path from the old way of doing things to
the new.
npm run transpile
Works on files under js/react/
Outputs files right next to the .tsx file
This is part of our `grunt dev` task, as well as the default grunt task,
which does everything else necessary to get a raw git checkout ready to
run.
Fixed: White block at bottom of conversation panel in iOS theme
(#2144 and #2153)
Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(1c6d91b59c)
Dev:
- Introduce IndexedDB index on `messages` store tracking
`schemaVersion` (#2128)
- Preparation for encrypted backups
(cea42bde7d)
- Updates to structure of exported data - messages.zip, flat list of
attachments (6d8f4b7b6e)
