mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Jitter updater poll timeout

Browse source
This commit is contained in:
Fedor Indutny 2024-02-14 10:27:31 -08:00 committed by GitHub
parent 4a41e87173
commit fe27910221
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 30 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
ts/updater/common.ts
View file

@ -25,6 +25,7 @@ import { DialogType } from '../types/Dialogs';
import * as Errors from '../types/errors';
import { isAlpha, isBeta, isStaging } from '../util/version';
import { strictAssert } from '../util/assert';
import { drop } from '../util/drop';
import * as packageJson from '../../package.json';
import {
@ -46,7 +47,7 @@ import {
isValidPreparedData as isValidDifferentialData,
} from './differential';
const INTERVAL = 30 * durations.MINUTE;
const POLL_INTERVAL = 30 * durations.MINUTE;
type JSONVendorSchema = {
minOSVersion?: string;
@ -148,13 +149,7 @@ export abstract class Updater {
public async start(): Promise<void> {
this.logger.info('updater/start: starting checks...');
setInterval(async () => {
try {
await this.checkForUpdatesMaybeInstall();
} catch (error) {
this.logger.error(`updater/start: ${Errors.toLogFormat(error)}`);
}
}, INTERVAL);
this.schedulePoll();
await this.deletePreviousInstallers();
await this.checkForUpdatesMaybeInstall();
@ -216,6 +211,33 @@ export abstract class Updater {
// Private methods
//
private schedulePoll(): void {
const now = Date.now();
const earliestPollTime = now - (now % POLL_INTERVAL) + POLL_INTERVAL;
const selectedPollTime = Math.round(
earliestPollTime + Math.random() * POLL_INTERVAL
);
const timeoutMs = selectedPollTime - now;
this.logger.info(`updater/start: polling in ${timeoutMs}ms`);
setTimeout(() => {
drop(this.safePoll());
}, timeoutMs);
}
private async safePoll(): Promise<void> {
try {
this.logger.info('updater/start: polling now');
await this.checkForUpdatesMaybeInstall();
} catch (error) {
this.logger.error(`updater/start: ${Errors.toLogFormat(error)}`);
} finally {
this.schedulePoll();
}
}
private async downloadAndInstall(
updateInfo: UpdateInformationType,
mode: DownloadMode