Remove unnecessary disables of consistent-return lint rule

This commit is contained in:
Evan Hahn 2021-09-16 15:25:55 -05:00 committed by GitHub
parent f937eba94e
commit fda21edd23
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 1 additions and 12 deletions

View file

@ -118,7 +118,6 @@ export class GroupNotification extends React.Component<Props> {
<Intl i18n={i18n} id={leftKey} components={[otherPeopleWithCommas]} /> <Intl i18n={i18n} id={leftKey} components={[otherPeopleWithCommas]} />
); );
case 'general': case 'general':
// eslint-disable-next-line consistent-return
return; return;
default: default:
throw missingCaseError(type); throw missingCaseError(type);

View file

@ -1447,7 +1447,6 @@ export class Message extends React.PureComponent<Props, State> {
</div> </div>
{reactionPickerRoot && {reactionPickerRoot &&
createPortal( createPortal(
// eslint-disable-next-line consistent-return
<Popper <Popper
placement="top" placement="top"
modifiers={[ modifiers={[
@ -1758,7 +1757,7 @@ export class Message extends React.PureComponent<Props, State> {
return; return;
} }
// eslint-disable-next-line consistent-return, no-nested-ternary // eslint-disable-next-line no-nested-ternary
return isTapToViewError return isTapToViewError
? i18n('incomingError') ? i18n('incomingError')
: direction === 'outgoing' : direction === 'outgoing'

View file

@ -368,7 +368,6 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
return; return;
} }
// eslint-disable-next-line consistent-return
return list.Grid; return list.Grid;
}; };
@ -381,7 +380,6 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
return; return;
} }
// eslint-disable-next-line consistent-return
return grid._scrollingContainer as HTMLDivElement; return grid._scrollingContainer as HTMLDivElement;
}; };
@ -894,7 +892,6 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
return; return;
} }
// eslint-disable-next-line consistent-return
return index; return index;
} }
@ -904,7 +901,6 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
return; return;
} }
// eslint-disable-next-line consistent-return
return this.fromItemIndexToRow(oldestUnreadIndex) - 1; return this.fromItemIndexToRow(oldestUnreadIndex) - 1;
} }
@ -916,7 +912,6 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
const last = items.length - 1; const last = items.length - 1;
// eslint-disable-next-line consistent-return
return this.fromItemIndexToRow(last) + 1; return this.fromItemIndexToRow(last) + 1;
} }

View file

@ -660,7 +660,6 @@ async function fetchManifest(
} }
try { try {
// eslint-disable-next-line consistent-return
return decryptManifest(encryptedManifest); return decryptManifest(encryptedManifest);
} catch (err) { } catch (err) {
await stopStorageServiceSync(); await stopStorageServiceSync();

View file

@ -341,7 +341,6 @@ export default class AccountManager extends EventTarget {
return; return;
} }
// eslint-disable-next-line consistent-return
return store return store
.getIdentityKeyPair(ourUuid) .getIdentityKeyPair(ourUuid)
.then( .then(

View file

@ -654,11 +654,9 @@ export class ConversationView extends window.Backbone.View<ConversationModel> {
const expires = window.moment(muteExpiresAt); const expires = window.moment(muteExpiresAt);
if (today.isSame(expires, 'day')) { if (today.isSame(expires, 'day')) {
// eslint-disable-next-line consistent-return
return expires.format('hh:mm A'); return expires.format('hh:mm A');
} }
// eslint-disable-next-line consistent-return
return expires.format('M/D/YY, hh:mm A'); return expires.format('M/D/YY, hh:mm A');
} }