Add npmrc to use legacy peer deps everywhere

.github/workflows/benchmark.yml

@@ -46,7 +46,7 @@ jobs:
 
     - name: Install Desktop node_modules
       if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-      run: npm ci --legacy-peer-deps
+      run: npm ci
       env:
         NPM_CONFIG_LOGLEVEL: verbose
 
@@ -145,7 +145,7 @@ jobs:
     - name: Build benchmark repo
       working-directory: benchmark-results
       run: |
-        npm ci --legacy-peer-deps
+        npm ci
         npm run build
 
     - name: Publish to DataDog

.github/workflows/ci.yml

@@ -42,7 +42,7 @@ jobs:
 
     - name: Install Desktop node_modules
       if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-      run: npm ci --legacy-peer-deps
+      run: npm ci
       env:
         NPM_CONFIG_LOGLEVEL: verbose
 
@@ -90,7 +90,7 @@ jobs:
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'package-lock.json', 'patches/**') }}
     - name: Install Desktop node_modules
       if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-      run: npm ci --legacy-peer-deps
+      run: npm ci
       env:
         NPM_CONFIG_LOGLEVEL: verbose
 
@@ -143,7 +143,7 @@ jobs:
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'package-lock.json', 'patches/**') }}
     - name: Install Desktop node_modules
       if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-      run: npm ci --legacy-peer-deps
+      run: npm ci
       env:
         NPM_CONFIG_LOGLEVEL: verbose
 
@@ -214,7 +214,7 @@ jobs:
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'package-lock.json', 'patches/**') }}
     - name: Install Desktop node_modules
       if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-      run: npm ci --legacy-peer-deps
+      run: npm ci
       env:
         CHILD_CONCURRENCY: 1
         NPM_CONFIG_LOGLEVEL: verbose
@@ -270,7 +270,7 @@ jobs:
         node-version: '18.17.1'
 
     - name: Install Sticker Creator node_modules
-      run: npm ci --legacy-peer-deps
+      run: npm ci
 
     - name: Build Sticker Creator
       run: npm run build
@@ -321,7 +321,7 @@ jobs:
 
     - name: Install Desktop node_modules
       if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-      run: npm ci --legacy-peer-deps
+      run: npm ci
       env:
         NPM_CONFIG_LOGLEVEL: verbose
 

.github/workflows/danger.yml

@@ -25,7 +25,7 @@ jobs:
           key: danger-${{ runner.os }}-${{ hashFiles('danger/package.json', 'danger/package-lock.json') }}
       - name: Install danger node_modules
         if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-        run: cd danger && npm ci --legacy-peer-deps
+        run: cd danger && npm ci
       - name: Run DangerJS
         run: npm run danger:ci
         env:

.github/workflows/stories.yml

@@ -28,7 +28,7 @@ jobs:
           key: ${{ runner.os }}-${{ hashFiles('package.json', 'package-lock.json', 'patches/**') }}
       - name: Install Desktop node_modules
         if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-        run: npm ci --legacy-peer-deps
+        run: npm ci
         env:
           CHILD_CONCURRENCY: 1
           NPM_CONFIG_LOGLEVEL: verbose

.npmrc

@@ -0,0 +1 @@
+legacy-peer-deps=true

CONTRIBUTING.md

@@ -54,10 +54,10 @@ Now, run these commands in your preferred terminal in a good directory for devel
 ```
 git clone https://github.com/signalapp/Signal-Desktop.git
 cd Signal-Desktop
-npm install --legacy-peer-deps  # Install and build dependencies (this will take a while)
-npm run generate                # Generate final JS and CSS assets
-npm test                        # A good idea to make sure tests run first
-npm start                       # Start Signal!
+npm install       # Install and build dependencies (this will take a while)
+npm run generate  # Generate final JS and CSS assets
+npm test          # A good idea to make sure tests run first
+npm start         # Start Signal!
 ```
 
 You'll need to restart the application regularly to see your changes, as there

danger/.npmrc

@@ -0,0 +1 @@
+legacy-peer-deps=true