mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Update which messages affect chat list presence on import

Browse source
This commit is contained in:
trevor-signal 2025-01-23 16:28:21 -05:00 • committed by GitHub
parent eab04b2acd
commit fb8c46fde1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 24 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
ts/services/backups/import.ts
View file

@ -1717,18 +1717,42 @@ export class BackupImportStream extends Writable {
* Some update messages should not affect the chat's position in the left pane chat * Some update messages should not affect the chat's position in the left pane chat
* list. For example, conversations with only an identity update (SN change) message * list. For example, conversations with only an identity update (SN change) message
* should not show in the left pane. * should not show in the left pane.
*
* iOS list: /main/SignalServiceKit/Messages/Interactions/TSInteraction.swift
*/ */
#shouldChatItemAffectChatListPresence(item: Backups.IChatItem): boolean { #shouldChatItemAffectChatListPresence(item: Backups.IChatItem): boolean {
if (!item.updateMessage) { if (!item.updateMessage) {
return true; return true;
} }
if (
item.updateMessage.profileChange ||
item.updateMessage.learnedProfileChange ||
item.updateMessage.sessionSwitchover ||
item.updateMessage.threadMerge
) {
return false;
}
if (
item.updateMessage.groupChange?.updates?.every(
update =>
Boolean(update.groupMemberLeftUpdate) ||
Boolean(update.groupV2MigrationUpdate)
)
) {
return false;
}
if (item.updateMessage.simpleUpdate) { if (item.updateMessage.simpleUpdate) {
switch (item.updateMessage.simpleUpdate.type) { switch (item.updateMessage.simpleUpdate.type) {
case Backups.SimpleChatUpdate.Type.IDENTITY_UPDATE: case Backups.SimpleChatUpdate.Type.IDENTITY_UPDATE:
case Backups.SimpleChatUpdate.Type.CHANGE_NUMBER: case Backups.SimpleChatUpdate.Type.CHANGE_NUMBER:
case Backups.SimpleChatUpdate.Type.MESSAGE_REQUEST_ACCEPTED: case Backups.SimpleChatUpdate.Type.MESSAGE_REQUEST_ACCEPTED:
case Backups.SimpleChatUpdate.Type.REPORTED_SPAM: case Backups.SimpleChatUpdate.Type.REPORTED_SPAM:
case Backups.SimpleChatUpdate.Type.IDENTITY_DEFAULT:
case Backups.SimpleChatUpdate.Type.IDENTITY_VERIFIED:
case Backups.SimpleChatUpdate.Type.UNKNOWN:
case undefined: case undefined:
case null: case null:
return false; return false;
@ -1738,14 +1762,11 @@ export class BackupImportStream extends Writable {
case Backups.SimpleChatUpdate.Type.BLOCKED: case Backups.SimpleChatUpdate.Type.BLOCKED:
case Backups.SimpleChatUpdate.Type.CHAT_SESSION_REFRESH: case Backups.SimpleChatUpdate.Type.CHAT_SESSION_REFRESH:
case Backups.SimpleChatUpdate.Type.END_SESSION: case Backups.SimpleChatUpdate.Type.END_SESSION:
case Backups.SimpleChatUpdate.Type.IDENTITY_DEFAULT:
case Backups.SimpleChatUpdate.Type.IDENTITY_VERIFIED:
case Backups.SimpleChatUpdate.Type.JOINED_SIGNAL: case Backups.SimpleChatUpdate.Type.JOINED_SIGNAL:
case Backups.SimpleChatUpdate.Type.PAYMENTS_ACTIVATED: case Backups.SimpleChatUpdate.Type.PAYMENTS_ACTIVATED:
case Backups.SimpleChatUpdate.Type.PAYMENT_ACTIVATION_REQUEST: case Backups.SimpleChatUpdate.Type.PAYMENT_ACTIVATION_REQUEST:
case Backups.SimpleChatUpdate.Type.RELEASE_CHANNEL_DONATION_REQUEST: case Backups.SimpleChatUpdate.Type.RELEASE_CHANNEL_DONATION_REQUEST:
case Backups.SimpleChatUpdate.Type.UNBLOCKED: case Backups.SimpleChatUpdate.Type.UNBLOCKED:
case Backups.SimpleChatUpdate.Type.UNKNOWN:
case Backups.SimpleChatUpdate.Type.UNSUPPORTED_PROTOCOL_MESSAGE: case Backups.SimpleChatUpdate.Type.UNSUPPORTED_PROTOCOL_MESSAGE:
return true; return true;
default: default:
@ -1753,18 +1774,6 @@ export class BackupImportStream extends Writable {
} }
} }
if (
item.updateMessage.groupChange?.updates?.every(update =>
Boolean(update.groupMemberLeftUpdate)
)
) {
return false;
}
if (item.updateMessage.profileChange) {
return false;
}
return true; return true;
} }