mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix disabling spellcheck with <Input>

Browse source
This commit is contained in:
Evan Hahn 2022-01-13 17:27:14 -06:00 • committed by GitHub
parent 393b740fe6
commit f9faf9b759
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
ts/components/Input.stories.tsx
View file

@ -1,4 +1,4 @@
// Copyright 2021 Signal Messenger, LLC // Copyright 2021-2022 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only // SPDX-License-Identifier: AGPL-3.0-only
import React, { useState } from 'react'; import React, { useState } from 'react';
@ -18,6 +18,7 @@ const stories = storiesOf('Components/Input', module);
const createProps = (overrideProps: Partial<PropsType> = {}): PropsType => ({ const createProps = (overrideProps: Partial<PropsType> = {}): PropsType => ({
disabled: Boolean(overrideProps.disabled), disabled: Boolean(overrideProps.disabled),
disableSpellcheck: overrideProps.disableSpellcheck,
expandable: Boolean(overrideProps.expandable), expandable: Boolean(overrideProps.expandable),
hasClearButton: Boolean(overrideProps.hasClearButton), hasClearButton: Boolean(overrideProps.hasClearButton),
i18n, i18n,
@ -92,3 +93,11 @@ stories.add('disabled', () => (
})} })}
/> />
)); ));
stories.add('spellcheck disabled', () => (
<Controller
{...createProps({
disableSpellcheck: true,
})}
/>
));

4
ts/components/Input.tsx
View file

@ -1,4 +1,4 @@
// Copyright 2021 Signal Messenger, LLC // Copyright 2021-2022 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only // SPDX-License-Identifier: AGPL-3.0-only
import type { ClipboardEvent, ReactNode } from 'react'; import type { ClipboardEvent, ReactNode } from 'react';
@ -203,7 +203,7 @@ export const Input = forwardRef<
isLarge && getClassName('__input--large') isLarge && getClassName('__input--large')
), ),
disabled: Boolean(disabled), disabled: Boolean(disabled),
spellcheck: disableSpellcheck ? 'false' : 'true', spellCheck: !disableSpellcheck,
onChange: handleChange, onChange: handleChange,
onKeyDown: handleKeyDown, onKeyDown: handleKeyDown,
onPaste: handlePaste, onPaste: handlePaste,