mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix pluralization of an error message

Browse source 
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
This commit is contained in:
automated-signal 2024-06-18 14:51:54 -05:00 committed by GitHub
parent c2141a1b04
commit f94e424caf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
_locales/en/messages.json
View file

@ -5588,10 +5588,18 @@
},
"icu:ProfileEditor--username--check-character-min": {
"messageformat": "Usernames must have at least {min, number} characters.",
"description": "Shown if user has attempted to enter a username with too few characters - currently min is 3"
"description": "(Deleted 2024/06/13) Shown if user has attempted to enter a username with too few characters - currently min is 3"
},
"icu:ProfileEditor--username--check-character-max": {
"messageformat": "Usernames must have at most {max, number} characters.",
"description": "(Deleted 2024/06/13) Shown if user has attempted to enter a username with too many characters - currently min is 25"
},
"icu:ProfileEditor--username--check-character-min-plural": {
"messageformat": "Usernames must have at least {min, plural, one {# character} other {# characters}}.",
"description": "Shown if user has attempted to enter a username with too few characters - currently min is 3"
},
"icu:ProfileEditor--username--check-character-max-plural": {
"messageformat": "Usernames must have at most {max, plural, one {# character} other {# characters}}.",
"description": "Shown if user has attempted to enter a username with too many characters - currently min is 25"
},
"icu:ProfileEditor--username--check-discriminator-min": {

4
ts/components/EditUsernameModalBody.tsx
View file

@ -179,12 +179,12 @@ export function EditUsernameModalBody({
return undefined;
}
if (error === UsernameReservationError.NotEnoughCharacters) {
return i18n('icu:ProfileEditor--username--check-character-min', {
return i18n('icu:ProfileEditor--username--check-character-min-plural', {
min: minNickname,
});
}
if (error === UsernameReservationError.TooManyCharacters) {
return i18n('icu:ProfileEditor--username--check-character-max', {
return i18n('icu:ProfileEditor--username--check-character-max-plural', {
max: maxNickname,
});
}