Standardize on showConversation function, delete unused functions

This commit is contained in:
Scott Nonnenberg 2022-12-14 11:05:32 -08:00 committed by GitHub
parent 1dc3ed914f
commit f2f1c3c021
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
35 changed files with 174 additions and 198 deletions

View file

@ -13,14 +13,17 @@ import type {
export type Props = {
bodyRanges?: HydratedBodyRangesType;
direction?: 'incoming' | 'outgoing';
openConversation?: (conversationId: string, messageId?: string) => void;
showConversation?: (options: {
conversationId: string;
messageId?: string;
}) => unknown;
text: string;
};
export function AtMentionify({
bodyRanges,
direction,
openConversation,
showConversation,
text,
}: Props): JSX.Element {
if (!bodyRanges) {
@ -53,17 +56,17 @@ export function AtMentionify({
className={`MessageBody__at-mention MessageBody__at-mention--${direction}`}
key={range.start}
onClick={() => {
if (openConversation) {
openConversation(range.conversationID);
if (showConversation) {
showConversation({ conversationId: range.conversationID });
}
}}
onKeyUp={e => {
if (
e.target === e.currentTarget &&
e.keyCode === 13 &&
openConversation
showConversation
) {
openConversation(range.conversationID);
showConversation({ conversationId: range.conversationID });
}
}}
tabIndex={0}