Show the system contacts icon in more places

This commit is contained in:
Jamie Kyle 2024-03-25 12:22:35 -07:00 committed by GitHub
parent 6bc6cc64c4
commit f29fc7cf9d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 132 additions and 34 deletions

View file

@ -121,3 +121,9 @@
} }
} }
} }
.ContactListItem__contact-icon {
width: 14px;
height: 14px;
color: currentColor;
}

View file

@ -29,6 +29,14 @@
white-space: nowrap; white-space: nowrap;
} }
&__name__contact-icon {
height: 22px;
width: 22px;
@include any-theme {
background-color: currentColor;
}
}
&__name__chevron { &__name__chevron {
flex-shrink: 0; flex-shrink: 0;

View file

@ -21,14 +21,17 @@
&__title { &__title {
@include font-title-1; @include font-title-1;
font-weight: 400; font-weight: 400;
align-items: baseline;
display: flex;
justify-content: center;
padding-bottom: 8px; padding-bottom: 8px;
padding-top: 12px; padding-top: 12px;
user-select: text; user-select: text;
} }
&__title-contact-icon {
width: 22px;
height: 22px;
background-color: currentColor;
}
&__subtitle { &__subtitle {
@include font-body-1; @include font-body-1;
color: $color-gray-60; color: $color-gray-60;

View file

@ -140,6 +140,20 @@ export function ContactDirect(): JSX.Element {
); );
} }
export function ContactInSystemContacts(): JSX.Element {
const contact = defaultConversations[0];
return (
<Wrapper
rows={[
{
type: RowType.Contact,
contact: { ...contact, systemGivenName: contact.title },
},
]}
/>
);
}
export function ContactDirectWithContextMenu(): JSX.Element { export function ContactDirectWithContextMenu(): JSX.Element {
return ( return (
<Wrapper <Wrapper

View file

@ -6,6 +6,7 @@ import classNames from 'classnames';
import { noop } from 'lodash'; import { noop } from 'lodash';
import { Manager, Reference, Popper } from 'react-popper'; import { Manager, Reference, Popper } from 'react-popper';
import type { StrictModifiers } from '@popperjs/core'; import type { StrictModifiers } from '@popperjs/core';
import { createPortal } from 'react-dom';
import type { Theme } from '../util/theme'; import type { Theme } from '../util/theme';
import { themeClassName } from '../util/theme'; import { themeClassName } from '../util/theme';
import { refMerger } from '../util/refMerger'; import { refMerger } from '../util/refMerger';
@ -169,6 +170,7 @@ export function Tooltip({
</TooltipEventWrapper> </TooltipEventWrapper>
)} )}
</Reference> </Reference>
{createPortal(
<Popper <Popper
placement={direction} placement={direction}
modifiers={[offsetDistanceModifier(12), ...popperModifiers]} modifiers={[offsetDistanceModifier(12), ...popperModifiers]}
@ -196,7 +198,9 @@ export function Tooltip({
</div> </div>
) )
} }
</Popper> </Popper>,
document.body
)}
</Manager> </Manager>
); );
} }

View file

@ -119,3 +119,11 @@ WithUnreadStories.args = {
hasStories: HasStories.Unread, hasStories: HasStories.Unread,
}; };
WithUnreadStories.storyName = 'Unread Stories'; WithUnreadStories.storyName = 'Unread Stories';
export const InSystemContacts = Template.bind({});
InSystemContacts.args = {
contact: {
...defaultContact,
systemGivenName: defaultContact.title,
},
};

View file

@ -23,6 +23,8 @@ import { RemoveGroupMemberConfirmationDialog } from './RemoveGroupMemberConfirma
import { missingCaseError } from '../../util/missingCaseError'; import { missingCaseError } from '../../util/missingCaseError';
import { UserText } from '../UserText'; import { UserText } from '../UserText';
import { Button, ButtonIconType, ButtonVariant } from '../Button'; import { Button, ButtonIconType, ButtonVariant } from '../Button';
import { isInSystemContacts } from '../../util/isInSystemContacts';
import { InContactsIcon } from '../InContactsIcon';
export type PropsDataType = { export type PropsDataType = {
areWeASubscriber: boolean; areWeASubscriber: boolean;
@ -200,7 +202,6 @@ export function ContactModal({
switch (view) { switch (view) {
case ContactModalView.Default: { case ContactModalView.Default: {
const preferredBadge: undefined | BadgeType = badges[0]; const preferredBadge: undefined | BadgeType = badges[0];
return ( return (
<Modal <Modal
modalName="ContactModal" modalName="ContactModal"
@ -249,6 +250,15 @@ export function ContactModal({
> >
<div className="ContactModal__name__text"> <div className="ContactModal__name__text">
<UserText text={contact.title} /> <UserText text={contact.title} />
{isInSystemContacts(contact) && (
<span>
{' '}
<InContactsIcon
className="ContactModal__name__contact-icon"
i18n={i18n}
/>
</span>
)}
</div> </div>
<i className="ContactModal__name__chevron" /> <i className="ContactModal__name__chevron" />
</button> </button>

View file

@ -142,6 +142,22 @@ export function Basic(): JSX.Element {
return <ConversationDetails {...props} />; return <ConversationDetails {...props} />;
} }
export function SystemContact(): JSX.Element {
const props = createProps();
const contact = getDefaultConversation();
return (
<ConversationDetails
{...props}
isGroup={false}
conversation={{
...contact,
systemGivenName: contact.title,
}}
/>
);
}
export function AsAdmin(): JSX.Element { export function AsAdmin(): JSX.Element {
const props = createProps(); const props = createProps();

View file

@ -15,6 +15,8 @@ import { assertDev } from '../../../util/assert';
import { BadgeDialog } from '../../BadgeDialog'; import { BadgeDialog } from '../../BadgeDialog';
import type { BadgeType } from '../../../badges/types'; import type { BadgeType } from '../../../badges/types';
import { UserText } from '../../UserText'; import { UserText } from '../../UserText';
import { isInSystemContacts } from '../../../util/isInSystemContacts';
import { InContactsIcon } from '../../InContactsIcon';
export type Props = { export type Props = {
areWeASubscriber: boolean; areWeASubscriber: boolean;
@ -211,7 +213,15 @@ export function ConversationDetailsHeader({
> >
<div className="ConversationDetailsHeader__title"> <div className="ConversationDetailsHeader__title">
<UserText text={conversation.title} /> <UserText text={conversation.title} />
{isInSystemContacts(conversation) && (
<span>
{' '}
<InContactsIcon
className="ConversationDetailsHeader__title-contact-icon"
i18n={i18n}
/>
</span>
)}
<span className="ConversationDetailsHeader__about-icon" /> <span className="ConversationDetailsHeader__about-icon" />
</div> </div>
</button> </button>

View file

@ -17,6 +17,7 @@ import { Intl } from '../Intl';
import { ConfirmationDialog } from '../ConfirmationDialog'; import { ConfirmationDialog } from '../ConfirmationDialog';
import { isSignalConversation } from '../../util/isSignalConversation'; import { isSignalConversation } from '../../util/isSignalConversation';
import { isInSystemContacts } from '../../util/isInSystemContacts'; import { isInSystemContacts } from '../../util/isInSystemContacts';
import { InContactsIcon } from '../InContactsIcon';
export type ContactListItemConversationType = Pick< export type ContactListItemConversationType = Pick<
ConversationType, ConversationType,
@ -281,7 +282,25 @@ export const ContactListItem: FunctionComponent<PropsType> = React.memo(
/> />
} }
trailing={trailing} trailing={trailing}
title={headerName} title={
<>
{headerName}
{isInSystemContacts({
type,
name,
systemGivenName,
systemFamilyName,
}) && (
<span>
{' '}
<InContactsIcon
className="ContactListItem__contact-icon"
i18n={i18n}
/>
</span>
)}
</>
}
subtitle={messageText} subtitle={messageText}
subtitleMaxLines={1} subtitleMaxLines={1}
onClick={onClick ? () => onClick(id) : undefined} onClick={onClick ? () => onClick(id) : undefined}