mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix legacy call-history messages without a callId

Browse source 
Co-authored-by: Scott Nonnenberg <scott@signal.org>
This commit is contained in:
Jamie Kyle 2023-08-16 17:11:09 -07:00 • committed by Jamie Kyle
parent 6f0401b847
commit ef0a3de636
17 changed files with 831 additions and 426 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ts/util/callingNotification.ts
View file

@ -22,7 +22,8 @@ export enum CallExternalState {
}
export type CallingNotificationType = Readonly<{
callHistory: CallHistoryDetails;
// In some older calls, we don't have a call id, this hardens against that.
callHistory: CallHistoryDetails | null;
callCreator: ConversationType | null;
callExternalState: CallExternalState;
deviceCount: number;
@ -110,8 +111,12 @@ function getGroupCallNotificationText(
export function getCallingNotificationText(
callingNotification: CallingNotificationType,
i18n: LocalizerType
): string {
): string | null {
const { callHistory, callCreator, callExternalState } = callingNotification;
if (callHistory == null) {
return null;
}
if (callHistory.mode === CallMode.Direct) {
return getDirectCallNotificationText(
callHistory.direction,
@ -123,11 +128,6 @@ export function getCallingNotificationText(
if (callHistory.mode === CallMode.Group) {
return getGroupCallNotificationText(callExternalState, callCreator, i18n);
}
if (callHistory.mode === CallMode.None) {
throw new Error(
'getCallingNotificationText: Cannot render call history details with mode = None'
);
}
throw missingCaseError(callHistory.mode);
}