mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Enable noImplicitOverride TypeScript compiler option

Browse source
This commit is contained in:
Evan Hahn 2021-11-12 17:44:20 -06:00 • committed by GitHub
parent 4490d9f2d0
commit ede34ecee3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
51 changed files with 339 additions and 194 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ts/textsecure/CDSSocket.ts
View file

@ -150,13 +150,13 @@ export class CDSSocket extends EventEmitter {
// EventEmitter types
public on(
public override on(
type: 'close',
callback: (code: number, reason?: string) => void
): this;
public on(type: 'error', callback: (error: Error) => void): this;
public override on(type: 'error', callback: (error: Error) => void): this;
public on(
public override on(
type: string | symbol,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
listener: (...args: Array<any>) => void
@ -164,11 +164,11 @@ export class CDSSocket extends EventEmitter {
return super.on(type, listener);
}
public emit(type: 'close', code: number, reason?: string): boolean;
public emit(type: 'error', error: Error): boolean;
public override emit(type: 'close', code: number, reason?: string): boolean;
public override emit(type: 'error', error: Error): boolean;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
public emit(type: string | symbol, ...args: Array<any>): boolean {
public override emit(type: string | symbol, ...args: Array<any>): boolean {
return super.emit(type, ...args);
}
}

6
ts/textsecure/Errors.ts
View file

@ -18,7 +18,7 @@ export type HTTPErrorHeadersType = {
};
export class HTTPError extends Error {
public readonly name = 'HTTPError';
public override readonly name = 'HTTPError';
public readonly code: number;
@ -48,10 +48,6 @@ export class HTTPError extends Error {
}
export class ReplayableError extends Error {
name: string;
message: string;
functionCode?: number;
constructor(options: {

73
ts/textsecure/MessageReceiver.ts
View file

@ -350,134 +350,149 @@ export default class MessageReceiver
// EventTarget types
//
public addEventListener(
public override addEventListener(
name: 'reconnect',
handler: (ev: ReconnectEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'empty',
handler: (ev: EmptyEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'progress',
handler: (ev: ProgressEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'typing',
handler: (ev: TypingEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'error',
handler: (ev: ErrorEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'delivery',
handler: (ev: DeliveryEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'decryption-error',
handler: (ev: DecryptionErrorEvent) => void
): void;
public addEventListener(name: 'sent', handler: (ev: SentEvent) => void): void;
public override addEventListener(
name: 'sent',
handler: (ev: SentEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'profileKeyUpdate',
handler: (ev: ProfileKeyUpdateEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'message',
handler: (ev: MessageEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'retry-request',
handler: (ev: RetryRequestEvent) => void
): void;
public addEventListener(name: 'read', handler: (ev: ReadEvent) => void): void;
public override addEventListener(
name: 'read',
handler: (ev: ReadEvent) => void
): void;
public addEventListener(name: 'view', handler: (ev: ViewEvent) => void): void;
public override addEventListener(
name: 'view',
handler: (ev: ViewEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'configuration',
handler: (ev: ConfigurationEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'viewOnceOpenSync',
handler: (ev: ViewOnceOpenSyncEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'messageRequestResponse',
handler: (ev: MessageRequestResponseEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'fetchLatest',
handler: (ev: FetchLatestEvent) => void
): void;
public addEventListener(name: 'keys', handler: (ev: KeysEvent) => void): void;
public override addEventListener(
name: 'keys',
handler: (ev: KeysEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'sticker-pack',
handler: (ev: StickerPackEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'verified',
handler: (ev: VerifiedEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'readSync',
handler: (ev: ReadSyncEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'viewSync',
handler: (ev: ViewSyncEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'contact',
handler: (ev: ContactEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'contactSync',
handler: (ev: ContactSyncEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'group',
handler: (ev: GroupEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'groupSync',
handler: (ev: GroupSyncEvent) => void
): void;
public addEventListener(
public override addEventListener(
name: 'envelope',
handler: (ev: EnvelopeEvent) => void
): void;
public addEventListener(name: string, handler: EventHandler): void {
public override addEventListener(name: string, handler: EventHandler): void {
return super.addEventListener(name, handler);
}
public removeEventListener(name: string, handler: EventHandler): void {
public override removeEventListener(
name: string,
handler: EventHandler
): void {
return super.removeEventListener(name, handler);
}

15
ts/textsecure/SocketManager.ts
View file

@ -626,10 +626,13 @@ export class SocketManager extends EventListener {
// EventEmitter types
public on(type: 'authError', callback: (error: HTTPError) => void): this;
public on(type: 'statusChange', callback: () => void): this;
public override on(
type: 'authError',
callback: (error: HTTPError) => void
): this;
public override on(type: 'statusChange', callback: () => void): this;
public on(
public override on(
type: string | symbol,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
listener: (...args: Array<any>) => void
@ -637,11 +640,11 @@ export class SocketManager extends EventListener {
return super.on(type, listener);
}
public emit(type: 'authError', error: HTTPError): boolean;
public emit(type: 'statusChange'): boolean;
public override emit(type: 'authError', error: HTTPError): boolean;
public override emit(type: 'statusChange'): boolean;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
public emit(type: string | symbol, ...args: Array<any>): boolean {
public override emit(type: string | symbol, ...args: Array<any>): boolean {
return super.emit(type, ...args);
}
}

4
ts/textsecure/WebsocketResources.ts
View file

@ -163,12 +163,12 @@ export default class WebSocketResource extends EventTarget {
this.addEventListener('close', () => this.onClose());
}
public addEventListener(
public override addEventListener(
name: 'close',
handler: (ev: CloseEvent) => void
): void;
public addEventListener(name: string, handler: EventHandler): void {
public override addEventListener(name: string, handler: EventHandler): void {
return super.addEventListener(name, handler);
}