mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Better logging for sealed sender, sender key distribution

Browse source
This commit is contained in:
Scott Nonnenberg 2021-07-23 15:37:04 -07:00 • committed by GitHub
parent 18140c4a9d
commit eba182f8d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ts/textsecure/MessageReceiver.ts
View file

@ -911,7 +911,7 @@ export default class MessageReceiver extends EventTarget {
return `${sender}.${envelope.sourceDevice} ${timestamp} (${envelope.id})`; return `${sender}.${envelope.sourceDevice} ${timestamp} (${envelope.id})`;
} }
return envelope.id; return `${timestamp} (${envelope.id})`;
} }
private clearRetryTimeout(): void { private clearRetryTimeout(): void {
@ -1322,8 +1322,6 @@ export default class MessageReceiver extends EventTarget {
const originalSource = envelope.source; const originalSource = envelope.source;
const originalSourceUuid = envelope.sourceUuid; const originalSourceUuid = envelope.sourceUuid;
const unidentifiedLogId = this.getEnvelopeId(envelope);
const newEnvelope: DecryptedEnvelope = { const newEnvelope: DecryptedEnvelope = {
...envelope, ...envelope,
@ -1385,10 +1383,11 @@ export default class MessageReceiver extends EventTarget {
); );
} }
const unidentifiedLogId = this.getEnvelopeId(newEnvelope);
if (newEnvelope.serverTimestamp > certificate.expiration()) { if (newEnvelope.serverTimestamp > certificate.expiration()) {
const envelopeId = this.getEnvelopeId(newEnvelope);
throw new Error( throw new Error(
`MessageReceiver.decryptSealedSender: Sender certificate is expired for envelope ${envelopeId}` `MessageReceiver.decryptSealedSender: Sender certificate is expired for envelope ${unidentifiedLogId}`
); );
} }

3
ts/textsecure/SendMessage.ts
View file

@ -1912,6 +1912,9 @@ export default class MessageSender {
): Promise<CallbackResultType> { ): Promise<CallbackResultType> {
const contentMessage = new Proto.Content(); const contentMessage = new Proto.Content();
const timestamp = Date.now(); const timestamp = Date.now();
window.log.info(
`sendSenderKeyDistributionMessage: Sending ${distributionId} with timestamp ${timestamp}`
);
const senderKeyDistributionMessage = await this.getSenderKeyDistributionMessage( const senderKeyDistributionMessage = await this.getSenderKeyDistributionMessage(
distributionId distributionId

6
ts/util/sendToGroup.ts
View file

@ -621,7 +621,7 @@ async function markIdentifierUnregistered(identifier: string) {
); );
conversation.setUnregistered(); conversation.setUnregistered();
await window.Signal.Data.saveConversation(conversation.attributes); await window.Signal.Data.updateConversation(conversation.attributes);
await window.textsecure.storage.protocol.archiveAllSessions(identifier); await window.textsecure.storage.protocol.archiveAllSessions(identifier);
} }
@ -975,7 +975,7 @@ async function resetSenderKey(conversation: ConversationModel): Promise<void> {
memberDevices: [], memberDevices: [],
}, },
}); });
await window.Signal.Data.saveConversation(conversation.attributes); await window.Signal.Data.updateConversation(conversation.attributes);
} }
function getAccessKey( function getAccessKey(
@ -1047,7 +1047,7 @@ async function fetchKeysForIdentifier(
emptyConversation.set({ emptyConversation.set({
sealedSender: SEALED_SENDER.DISABLED, sealedSender: SEALED_SENDER.DISABLED,
}); });
await window.Signal.Data.saveConversation(emptyConversation.attributes); await window.Signal.Data.updateConversation(emptyConversation.attributes);
} }
} catch (error) { } catch (error) {
if (error.name === 'UnregisteredUserError') { if (error.name === 'UnregisteredUserError') {