Simplify database migrations

ts/sql/migrations/1070-attachment-backup.ts

@@ -3,53 +3,35 @@
 
 import type { Database } from '@signalapp/sqlcipher';
 
-import type { LoggerType } from '../../types/Logging';
+export default function updateToSchemaVersion1070(db: Database): void {
+  db.exec(`
+    CREATE TABLE attachment_backup_jobs (
+      mediaName TEXT NOT NULL PRIMARY KEY,
+      type TEXT NOT NULL,
+      data TEXT NOT NULL,
+      receivedAt INTEGER NOT NULL,
 
-export const version = 1070;
+      -- job manager fields
+      attempts INTEGER NOT NULL,
+      active INTEGER NOT NULL,
+      retryAfter INTEGER,
+      lastAttemptTimestamp INTEGER
+    ) STRICT;
 
-export function updateToSchemaVersion1070(
-  currentVersion: number,
-  db: Database,
-  logger: LoggerType
-): void {
-  if (currentVersion >= 1070) {
-    return;
-  }
+    CREATE INDEX attachment_backup_jobs_receivedAt
+      ON attachment_backup_jobs (
+        receivedAt
+    );
 
-  db.transaction(() => {
-    db.exec(`
-      CREATE TABLE attachment_backup_jobs (
-        mediaName TEXT NOT NULL PRIMARY KEY,
-        type TEXT NOT NULL,
-        data TEXT NOT NULL,
-        receivedAt INTEGER NOT NULL,
+    CREATE INDEX attachment_backup_jobs_type_receivedAt
+      ON attachment_backup_jobs (
+        type, receivedAt
+    );
 
-        -- job manager fields
-        attempts INTEGER NOT NULL,
-        active INTEGER NOT NULL,
-        retryAfter INTEGER,
-        lastAttemptTimestamp INTEGER
-      ) STRICT;
-
-      CREATE INDEX attachment_backup_jobs_receivedAt
-        ON attachment_backup_jobs (
-          receivedAt
-      );
-
-      CREATE INDEX attachment_backup_jobs_type_receivedAt
-        ON attachment_backup_jobs (
-          type, receivedAt
-      ); 
-
-      CREATE TABLE backup_cdn_object_metadata (
-        mediaId TEXT NOT NULL PRIMARY KEY,
-        cdnNumber INTEGER NOT NULL,
-        sizeOnBackupCdn INTEGER
-      ) STRICT;
-    `);
-
-    db.pragma('user_version = 1070');
-  })();
-
-  logger.info('updateToSchemaVersion1070: success!');
+    CREATE TABLE backup_cdn_object_metadata (
+      mediaId TEXT NOT NULL PRIMARY KEY,
+      cdnNumber INTEGER NOT NULL,
+      sizeOnBackupCdn INTEGER
+    ) STRICT;
+  `);
 }