Revert "Periodically optimize FTS table"

This reverts commit 5dfdde998b.

ts/background.ts

@@ -55,7 +55,6 @@ import { senderCertificateService } from './services/senderCertificate';
 import { GROUP_CREDENTIALS_KEY } from './services/groupCredentialFetcher';
 import * as KeyboardLayout from './services/keyboardLayout';
 import * as StorageService from './services/storage';
-import { optimizeFTS } from './services/ftsOptimizer';
 import { RoutineProfileRefresher } from './routineProfileRefresh';
 import { isOlderThan, toDayMillis } from './util/timestamp';
 import { isValidReactionEmoji } from './reactions/isValidReactionEmoji';
@@ -863,8 +862,6 @@ export async function startApp(): Promise<void> {
     if (newVersion) {
       await window.Signal.Data.cleanupOrphanedAttachments();
 
-      optimizeFTS();
-
       // Don't block on the following operation
       void window.Signal.Data.ensureFilePermissions();
     }

ts/models/conversations.ts

@@ -90,7 +90,6 @@ import { isNotNil } from '../util/isNotNil';
 import { dropNull } from '../util/dropNull';
 import { notificationService } from '../services/notifications';
 import { storageServiceUploadJob } from '../services/storage';
-import { scheduleOptimizeFTS } from '../services/ftsOptimizer';
 import { getSendOptions } from '../util/getSendOptions';
 import { isConversationAccepted } from '../util/isConversationAccepted';
 import {
@@ -5040,8 +5039,6 @@ export class ConversationModel extends window.Backbone
     await window.Signal.Data.removeAllMessagesInConversation(this.id, {
       logId: this.idForLogging(),
     });
-
-    scheduleOptimizeFTS();
   }
 
   getTitle(options?: { isShort?: boolean }): string {

ts/models/messages.ts

@@ -79,7 +79,6 @@ import { migrateLegacyReadStatus } from '../messages/migrateLegacyReadStatus';
 import { migrateLegacySendAttributes } from '../messages/migrateLegacySendAttributes';
 import { getOwn } from '../util/getOwn';
 import { markRead, markViewed } from '../services/MessageUpdater';
-import { scheduleOptimizeFTS } from '../services/ftsOptimizer';
 import { isMessageUnread } from '../util/isMessageUnread';
 import {
   isDirectConversation,
@@ -1185,8 +1184,6 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
     }
 
     await window.Signal.Data.deleteSentProtoByMessageId(this.id);
-
-    scheduleOptimizeFTS();
   }
 
   override isEmpty(): boolean {

ts/services/expiringMessagesDeletion.ts

@@ -8,7 +8,6 @@ import { clearTimeoutIfNecessary } from '../util/clearTimeoutIfNecessary';
 import { sleep } from '../util/sleep';
 import { SECOND } from '../util/durations';
 import * as Errors from '../types/errors';
-import { scheduleOptimizeFTS } from './ftsOptimizer';
 
 class ExpiringMessagesDeletionService {
   public update: typeof this.checkExpiringMessages;
@@ -65,10 +64,6 @@ class ExpiringMessagesDeletionService {
           conversation.decrementMessageCount();
         }
       });
-
-      if (messages.length > 0) {
-        scheduleOptimizeFTS();
-      }
     } catch (error) {
       window.SignalContext.log.error(
         'destroyExpiredMessages: Error deleting expired messages',

ts/services/ftsOptimizer.ts

@@ -1,63 +0,0 @@
-// Copyright 2023 Signal Messenger, LLC
-// SPDX-License-Identifier: AGPL-3.0-only
-
-import { debounce } from 'lodash';
-
-import { SECOND } from '../util/durations';
-import { sleep } from '../util/sleep';
-import { drop } from '../util/drop';
-import dataInterface from '../sql/Client';
-import type { FTSOptimizationStateType } from '../sql/Interface';
-import * as log from '../logging/log';
-
-const INTERACTIVITY_DELAY_MS = 50;
-
-class FTSOptimizer {
-  private isRunning = false;
-
-  public async run(): Promise<void> {
-    if (this.isRunning) {
-      return;
-    }
-    this.isRunning = true;
-
-    log.info('ftsOptimizer: starting');
-
-    let state: FTSOptimizationStateType | undefined;
-
-    const start = Date.now();
-
-    try {
-      do {
-        if (state !== undefined) {
-          // eslint-disable-next-line no-await-in-loop
-          await sleep(INTERACTIVITY_DELAY_MS);
-        }
-
-        // eslint-disable-next-line no-await-in-loop
-        state = await dataInterface.optimizeFTS(state);
-      } while (!state?.done);
-    } finally {
-      this.isRunning = false;
-    }
-
-    const duration = Date.now() - start;
-
-    if (!state) {
-      log.warn('ftsOptimizer: no final state');
-      return;
-    }
-
-    log.info(`ftsOptimizer: took ${duration}ms and ${state.steps} steps`);
-  }
-}
-
-const optimizer = new FTSOptimizer();
-
-export const optimizeFTS = (): void => {
-  drop(optimizer.run());
-};
-
-export const scheduleOptimizeFTS = debounce(optimizeFTS, SECOND, {
-  maxWait: 5 * SECOND,
-});

ts/sql/Interface.ts

@@ -360,11 +360,6 @@ export type GetAllStoriesResultType = ReadonlyArray<
   }
 >;
 
-export type FTSOptimizationStateType = Readonly<{
-  steps: number;
-  done?: boolean;
-}>;
-
 export type DataInterface = {
   close: () => Promise<void>;
   removeDB: () => Promise<void>;
@@ -709,10 +704,6 @@ export type DataInterface = {
   getMaxMessageCounter(): Promise<number | undefined>;
 
   getStatisticsForLogging(): Promise<Record<string, string>>;
-
-  optimizeFTS: (
-    state?: FTSOptimizationStateType
-  ) => Promise<FTSOptimizationStateType | undefined>;
 };
 
 export type ServerInterface = DataInterface & {

ts/sql/Server.ts

@@ -78,7 +78,6 @@ import type {
   DeleteSentProtoRecipientOptionsType,
   DeleteSentProtoRecipientResultType,
   EmojiType,
-  FTSOptimizationStateType,
   GetAllStoriesResultType,
   GetConversationRangeCenteredOnMessageResultType,
   GetKnownMessageAttachmentsResultType,
@@ -342,8 +341,6 @@ const dataInterface: ServerInterface = {
 
   getStatisticsForLogging,
 
-  optimizeFTS,
-
   // Server-only
 
   initialize,
@@ -5413,48 +5410,6 @@ async function removeKnownDraftAttachments(
   return Object.keys(lookup);
 }
 
-const OPTIMIZE_FTS_PAGE_COUNT = 64;
-
-// This query is incremental. It gets the `state` from the return value of
-// previous `optimizeFTS` call. When `state.done` is `true` - optimization is
-// complete.
-async function optimizeFTS(
-  state?: FTSOptimizationStateType
-): Promise<FTSOptimizationStateType | undefined> {
-  // See https://www.sqlite.org/fts5.html#the_merge_command
-  let pageCount = OPTIMIZE_FTS_PAGE_COUNT;
-  if (state === undefined) {
-    pageCount = -pageCount;
-  }
-  const db = getInstance();
-  const getChanges = prepare(db, 'SELECT total_changes() as changes;', {
-    pluck: true,
-  });
-
-  const changeDifference = db.transaction(() => {
-    const before: number = getChanges.get({});
-
-    prepare(
-      db,
-      `
-        INSERT INTO messages_fts(messages_fts, rank) VALUES ('merge', $pageCount);
-      `
-    ).run({ pageCount });
-
-    const after: number = getChanges.get({});
-
-    return after - before;
-  })();
-
-  const nextSteps = (state?.steps ?? 0) + 1;
-
-  // From documentation:
-  // "If the difference is less than 2, then the 'merge' command was a no-op"
-  const done = changeDifference < 2;
-
-  return { steps: nextSteps, done };
-}
-
 async function getJobsInQueue(queueType: string): Promise<Array<StoredJob>> {
   const db = getInstance();
   return getJobsInQueueSync(db, queueType);