Call Disposition

ts/sql/Interface.ts

@@ -546,6 +546,10 @@ export type DataInterface = {
   getLastConversationMessage(options: {
     conversationId: string;
   }): Promise<MessageType | undefined>;
+  getCallHistoryMessageByCallId(
+    conversationId: string,
+    callId: string
+  ): Promise<string | void>;
   hasGroupCallHistoryMessage: (
     conversationId: string,
     eraId: string

ts/sql/Server.ts

@@ -256,6 +256,7 @@ const dataInterface: ServerInterface = {
   getConversationRangeCenteredOnMessage,
   getConversationMessageStats,
   getLastConversationMessage,
+  getCallHistoryMessageByCallId,
   hasGroupCallHistoryMessage,
   migrateConversationMessages,
 
@@ -3009,6 +3010,32 @@ async function getConversationRangeCenteredOnMessage({
   })();
 }
 
+async function getCallHistoryMessageByCallId(
+  conversationId: string,
+  callId: string
+): Promise<string | void> {
+  const db = getInstance();
+
+  const id: string | void = db
+    .prepare<Query>(
+      `
+      SELECT id
+      FROM messages
+      WHERE conversationId = $conversationId
+        AND type = 'call-history'
+        AND callMode = 'Direct'
+        AND callId = $callId
+    `
+    )
+    .pluck()
+    .get({
+      conversationId,
+      callId,
+    });
+
+  return id;
+}
+
 async function hasGroupCallHistoryMessage(
   conversationId: string,
   eraId: string

ts/sql/migrations/72-optimize-call-id-message-lookup.ts

@@ -0,0 +1,38 @@
+// Copyright 2021 Signal Messenger, LLC
+// SPDX-License-Identifier: AGPL-3.0-only
+
+import type { Database } from '@signalapp/better-sqlite3';
+import type { LoggerType } from '../../types/Logging';
+
+export default function updateToSchemaVersion72(
+  currentVersion: number,
+  db: Database,
+  logger: LoggerType
+): void {
+  if (currentVersion >= 72) {
+    return;
+  }
+
+  db.transaction(() => {
+    db.exec(
+      `
+      ALTER TABLE messages
+        ADD COLUMN callId TEXT
+        GENERATED ALWAYS AS (
+          json_extract(json, '$.callHistoryDetails.callId')
+        );
+      ALTER TABLE messages
+        ADD COLUMN callMode TEXT
+        GENERATED ALWAYS AS (
+          json_extract(json, '$.callHistoryDetails.callMode')
+        );
+      CREATE INDEX messages_call ON messages
+        (conversationId, type, callMode, callId);
+      `
+    );
+
+    db.pragma('user_version = 72');
+  })();
+
+  logger.info('updateToSchemaVersion72: success!');
+}

ts/sql/migrations/index.ts

@@ -47,6 +47,7 @@ import updateToSchemaVersion68 from './68-drop-deprecated-columns';
 import updateToSchemaVersion69 from './69-group-call-ring-cancellations';
 import updateToSchemaVersion70 from './70-story-reply-index';
 import updateToSchemaVersion71 from './71-merge-notifications';
+import updateToSchemaVersion72 from './72-optimize-call-id-message-lookup';
 
 function updateToSchemaVersion1(
   currentVersion: number,
@@ -1963,6 +1964,7 @@ export const SCHEMA_VERSIONS = [
 
   updateToSchemaVersion70,
   updateToSchemaVersion71,
+  updateToSchemaVersion72,
 ];
 
 export function updateSchema(db: Database, logger: LoggerType): void {