Persist overlay overflow in conversation list

This commit is contained in:
Evan Hahn 2021-10-07 10:24:10 -05:00 committed by GitHub
parent a537204fc0
commit e346fb1f90
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions

View file

@ -340,7 +340,11 @@ export const ConversationList: React.FC<PropsType> = ({
rowHeight={calculateRowHeight}
rowRenderer={renderRow}
scrollToIndex={scrollToRowIndex}
style={{ overflow: scrollable ? 'overlay' : 'hidden' }}
style={{
// See `<Timeline>` for an explanation of this `any` cast.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
overflowY: scrollable ? ('overlay' as any) : 'hidden',
}}
tabIndex={-1}
width={width}
/>

View file

@ -1365,7 +1365,16 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
scrollToIndex={scrollToIndex}
tabIndex={-1}
width={width}
style={{ overflow: 'overlay' }}
style={{
// `overlay` is [a nonstandard value][0] so it's not supported. See [this
// issue][1].
//
// [0]: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#values
// [1]: https://github.com/frenic/csstype/issues/62#issuecomment-937238313
//
// eslint-disable-next-line @typescript-eslint/no-explicit-any
overflowY: 'overlay' as any,
}}
/>
);
}}