mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Soft assert for hydrating story context

Browse source
This commit is contained in:
Josh Perez 2022-05-11 19:47:19 -04:00 • committed by GitHub
parent a924591a8c
commit ddde85cdd8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ts/models/messages.ts
View file

@ -21,7 +21,7 @@ import {
import type { SentEventData } from '../textsecure/messageReceiverEvents';
import { isNotNil } from '../util/isNotNil';
import { isNormalNumber } from '../util/isNormalNumber';
import { strictAssert } from '../util/assert';
import { softAssert, strictAssert } from '../util/assert';
import { missingCaseError } from '../util/missingCaseError';
import { dropNull } from '../util/dropNull';
import type { ConversationModel } from './conversations';
@ -324,16 +324,16 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
if (!message) {
const conversation = this.getConversation();
strictAssert(
softAssert(
conversation && isDirectConversation(conversation.attributes),
'Hydrating story context on a non-private conversation'
'hydrateStoryContext: Not a type=direct conversation'
);
this.set({
storyReplyContext: {
attachment: undefined,
// This is ok to do because story replies only show in 1:1 conversations
// so the story that was quoted should be from the same conversation.
authorUuid: conversation.get('uuid'),
authorUuid: conversation?.get('uuid'),
// No messageId, referenced story not found!
messageId: '',
},