Optimize removeKnownAttachments

ts/sql/Server.ts

@@ -6182,7 +6182,7 @@ async function removeKnownAttachments(
   const lookup: Dictionary<boolean> = fromPairs(
     map(allAttachments, file => [file, true])
   );
-  const chunkSize = 50;
+  const chunkSize = 500;
 
   const total = await getMessageCount();
   logger.info(
@@ -6193,17 +6193,17 @@ async function removeKnownAttachments(
   let complete = false;
   let id: string | number = '';
 
-  while (!complete) {
+  const fetchMessages = db.prepare<Query>(
-    const rows: JSONRows = db
-      .prepare<Query>(
     `
       SELECT json FROM messages
       WHERE id > $id
       ORDER BY id ASC
       LIMIT $chunkSize;
     `
-      )
+  );
-      .all({
+
+  while (!complete) {
+    const rows: JSONRows = fetchMessages.all({
       id,
       chunkSize,
     });
@@ -6239,17 +6239,17 @@ async function removeKnownAttachments(
     `removeKnownAttachments: About to iterate through ${conversationTotal} conversations`
   );
 
-  while (!complete) {
+  const fetchConversations = db.prepare<Query>(
-    const rows = db
-      .prepare<Query>(
     `
       SELECT json FROM conversations
       WHERE id > $id
       ORDER BY id ASC
       LIMIT $chunkSize;
     `
-      )
+  );
-      .all({
+
+  while (!complete) {
+    const rows = fetchConversations.all({
       id,
       chunkSize,
     });