mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Notarization: Update electron-notarize and start using notarytool

Browse source
This commit is contained in:
Scott Nonnenberg 2022-05-03 10:07:16 -07:00 • committed by GitHub
parent ff87caf526
commit dad4fffb4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -267,7 +267,7 @@
"electron": "18.1.0", "electron": "18.1.0",
"electron-builder": "23.0.8", "electron-builder": "23.0.8",
"electron-mocha": "11.0.2", "electron-mocha": "11.0.2",
"electron-notarize": "0.1.1", "electron-notarize": "1.2.1",
"esbuild": "0.14.28", "esbuild": "0.14.28",
"eslint": "7.7.0", "eslint": "7.7.0",
"eslint-config-airbnb-typescript-prettier": "4.2.0", "eslint-config-airbnb-typescript-prettier": "4.2.0",

10
ts/scripts/notarize.ts
View file

@ -47,15 +47,25 @@ export async function afterSign({
return; return;
} }
const teamId = process.env.APPLE_TEAM_ID;
if (!teamId) {
console.warn(
'teamId must be provided in environment variable APPLE_TEAM_ID'
);
return;
}
console.log('Notarizing with...'); console.log('Notarizing with...');
console.log(` primaryBundleId: ${appBundleId}`); console.log(` primaryBundleId: ${appBundleId}`);
console.log(` username: ${appleId}`); console.log(` username: ${appleId}`);
console.log(` file: ${appPath}`); console.log(` file: ${appPath}`);
await notarize({ await notarize({
tool: 'notarytool',
appBundleId, appBundleId,
appPath, appPath,
appleId, appleId,
appleIdPassword, appleIdPassword,
teamId,
}); });
} }

10
yarn.lock
View file

@ -6130,13 +6130,13 @@ electron-mocha@11.0.2:
which "^2.0.2" which "^2.0.2"
yargs "^16.2.0" yargs "^16.2.0"
electron-notarize@0.1.1: electron-notarize@1.2.1:
version "0.1.1" version "1.2.1"
resolved "https://registry.yarnpkg.com/electron-notarize/-/electron-notarize-0.1.1.tgz#c3563d70c5e7b3315f44e8495b30050a8c408b91" resolved "https://registry.yarnpkg.com/electron-notarize/-/electron-notarize-1.2.1.tgz#347c18eca8e29dddadadee511b870c13d4008baf"
integrity sha512-TpKfJcz4LXl5jiGvZTs5fbEx+wUFXV5u8voeG5WCHWfY/cdgdD8lDZIZRqLVOtR3VO+drgJ9aiSHIO9TYn/fKg== integrity sha512-u/ECWhIrhkSQpZM4cJzVZ5TsmkaqrRo5LDC/KMbGF0sPkm53Ng59+M0zp8QVaql0obfJy9vlVT+4iOkAi2UDlA==
dependencies: dependencies:
debug "^4.1.1" debug "^4.1.1"
fs-extra "^8.0.1" fs-extra "^9.0.1"
electron-osx-sign@^0.6.0: electron-osx-sign@^0.6.0:
version "0.6.0" version "0.6.0"