mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Performance: Automate clean up of old material after hitting a limit in libsignal-protocol

Browse source
This commit is contained in:
Fedor Indutny 2021-04-13 08:52:26 -07:00 • committed by GitHub
commit d933e3a6fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 57 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

31
libtextsecure/libsignal-protocol.js
View file

@ -24690,6 +24690,25 @@ libsignal.SessionBuilder = function (storage, remoteAddress) {
this.processV3 = builder.processV3.bind(builder);
};
function cleanOldMessageKeys(messageKeys) {
var limit = 2000;
var counters = Object.keys(messageKeys);
if (counters.length <= limit) {
return;
}
console.log('cleaning old message keys', counters.length);
// Sort counters in increasing order
var intCounters = counters
.map(string => parseInt(string, 10))
.sort((a, b) => a - b);
while (intCounters.length > limit) {
delete messageKeys[intCounters.shift()];
}
}
function SessionCipher(storage, remoteAddress, options) {
this.remoteAddress = remoteAddress;
this.storage = storage;
@ -25028,8 +25047,13 @@ SessionCipher.prototype = {
throw error;
});
},
fillMessageKeys: function(chain, counter) {
fillMessageKeys: function(chain, counter, hasChanged = false) {
if (chain.chainKey.counter >= counter) {
// End of recursive iteration. Time to cleanup
if (hasChanged) {
cleanOldMessageKeys(chain.messageKeys);
}
return Promise.resolve(); // Already calculated
}
@ -25060,7 +25084,7 @@ SessionCipher.prototype = {
chain.messageKeys[chain.chainKey.counter + 1] = mac;
chain.chainKey.key = key;
chain.chainKey.counter += 1;
return this.fillMessageKeys(chain, counter);
return this.fillMessageKeys(chain, counter, true);
}.bind(this));
}.bind(this));
},
@ -25209,6 +25233,9 @@ libsignal.SessionCipher = function(storage, remoteAddress) {
this.deleteAllSessionsForDevice = cipher.deleteAllSessionsForDevice.bind(cipher);
};
// Only for tests
libsignal.SessionCipher.cleanOldMessageKeys = cleanOldMessageKeys;
/*
* jobQueue manages multiple queues indexed by device to serialize
* session io ops on the database.