mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fetch conversations once, clean up ConversationController API (#1420)

Browse source 
* Fetch conversations once, clean up ConversationController API

Race conditions around re-fetching have caused some problems recently,
so this removes the need to re-fetch conversations. They are fetched
once or saved once, and that is it. All interaction goes through the
ConversationController, which is the central source of truth.

We have two rules for Conversations:

1. If a conversation is in the ConversationController it doesn't need
   to be fetched, but its initial fetch/save might be in progress. You
   can wait for that fetch/save with conversation.initialPromise.
2. If a conversation is not already in the ConversationController, it's
   not yet in the database. It needs to be added to the
   ConversationController and saved to the database.

FREEBIE

* Remove Conversation.fetch() call in Message.handleDataMessage()

FREEBIE

* ConversationController.API cleanup: Fix two missing spots

FREEBIE
This commit is contained in:
Scott Nonnenberg 2017-09-01 09:10:41 -07:00 • committed by GitHub
parent 51cd28bb4a
commit d8ce198f55
10 changed files with 276 additions and 294 deletions
Download patch file Download diff file Expand all files Collapse all files

4
js/notifications.js
View file

@ -25,9 +25,7 @@
openInbox();
return;
}
var conversation = ConversationController.create({
id: last.get('conversationId')
});
var conversation = ConversationController.get(last.get('conversationId'));
openConversation(conversation);
this.clear();
},