mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix pluralization of a group notification

Browse source
This commit is contained in:
Fedor Indutny 2024-08-21 00:51:54 -07:00 committed by GitHub
parent 8fbcced59f
commit d767e14878
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
_locales/en/messages.json
View file

@ -4445,10 +4445,14 @@
},
"icu:GroupV2--admin-approval-bounce--one": {
"messageformat": "{joinerName} requested and cancelled their request to join via the group link",
"description": "Shown in timeline or conversation preview when v2 group changes"
"description": "(Deleted 2024/08/20) Shown in timeline or conversation preview when v2 group changes"
},
"icu:GroupV2--admin-approval-bounce": {
"messageformat": "{joinerName} requested and cancelled {numberOfRequests, number} requests to join via the group link",
"description": "(Deleted 2024/08/20) Shown in timeline or conversation preview when v2 group changes"
},
"icu:GroupV2--admin-approval-bounce--pluralized": {
"messageformat": "{joinerName} requested and cancelled {numberOfRequests, plural, one {their request} other {# requests}} to join via the group link",
"description": "Shown in timeline or conversation preview when v2 group changes"
},
"icu:GroupV2--group-link-add--disabled--you": {

14
ts/groupChange.ts
View file

@ -747,17 +747,13 @@ function renderChangeDetail<T extends string | JSX.Element>(
if (detail.type === 'admin-approval-bounce') {
const { aci, times, isApprovalPending } = detail;
let firstMessage: T | string;
if (times === 1) {
firstMessage = i18n('icu:GroupV2--admin-approval-bounce--one', {
joinerName: renderContact(aci),
});
} else {
firstMessage = i18n('icu:GroupV2--admin-approval-bounce', {
const firstMessage = i18n(
'icu:GroupV2--admin-approval-bounce--pluralized',
{
joinerName: renderContact(aci),
numberOfRequests: times,
});
}
}
);
if (!isApprovalPending) {
return firstMessage;