mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Disable class-methods-use-this lint rule

Browse source
This commit is contained in:
Evan Hahn 2021-11-04 16:04:51 -05:00 • committed by GitHub
parent 569a14e897
commit d6ffb08a63
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
35 changed files with 8 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ts/components/conversation/ContactDetail.tsx
View file

@ -1,4 +1,4 @@
// Copyright 2018-2020 Signal Messenger, LLC
// Copyright 2018-2021 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
import React from 'react';
@ -74,7 +74,6 @@ function getLabelForAddress(
}
export class ContactDetail extends React.Component<Props> {
// eslint-disable-next-line class-methods-use-this
public renderSendMessage({
hasSignalAccount,
i18n,
@ -109,7 +108,6 @@ export class ContactDetail extends React.Component<Props> {
);
}
// eslint-disable-next-line class-methods-use-this
public renderEmail(
items: Array<Email> | undefined,
i18n: LocalizerType
@ -133,7 +131,6 @@ export class ContactDetail extends React.Component<Props> {
});
}
// eslint-disable-next-line class-methods-use-this
public renderPhone(
items: Array<Phone> | undefined,
i18n: LocalizerType
@ -157,7 +154,6 @@ export class ContactDetail extends React.Component<Props> {
});
}
// eslint-disable-next-line class-methods-use-this
public renderAddressLine(value: string | undefined): JSX.Element | undefined {
if (!value) {
return undefined;
@ -166,7 +162,6 @@ export class ContactDetail extends React.Component<Props> {
return <div>{value}</div>;
}
// eslint-disable-next-line class-methods-use-this
public renderPOBox(
poBox: string | undefined,
i18n: LocalizerType
@ -182,7 +177,6 @@ export class ContactDetail extends React.Component<Props> {
);
}
// eslint-disable-next-line class-methods-use-this
public renderAddressLineTwo(address: PostalAddress): JSX.Element | null {
if (address.city || address.region || address.postcode) {
return (

1
ts/components/conversation/Quote.tsx
View file

@ -191,7 +191,6 @@ export class Quote extends React.Component<Props, State> {
);
}
// eslint-disable-next-line class-methods-use-this
public renderIcon(icon: string): JSX.Element {
return (
<div className="module-quote__icon-container">

2
ts/components/leftPane/LeftPaneArchiveHelper.tsx
View file

@ -27,8 +27,6 @@ export type LeftPaneArchivePropsType =
| LeftPaneArchiveBasePropsType
| (LeftPaneArchiveBasePropsType & LeftPaneSearchPropsType);
/* eslint-disable class-methods-use-this */
export class LeftPaneArchiveHelper extends LeftPaneHelper<LeftPaneArchivePropsType> {
private readonly archivedConversations: ReadonlyArray<ConversationListItemPropsType>;

2
ts/components/leftPane/LeftPaneChooseGroupMembersHelper.tsx
View file

@ -32,8 +32,6 @@ export type LeftPaneChooseGroupMembersPropsType = {
selectedContacts: Array<ConversationType>;
};
/* eslint-disable class-methods-use-this */
export class LeftPaneChooseGroupMembersHelper extends LeftPaneHelper<LeftPaneChooseGroupMembersPropsType> {
private readonly candidateContacts: ReadonlyArray<ConversationType>;

2
ts/components/leftPane/LeftPaneComposeHelper.tsx
View file

@ -32,8 +32,6 @@ enum TopButton {
StartNewConversation,
}
/* eslint-disable class-methods-use-this */
export class LeftPaneComposeHelper extends LeftPaneHelper<LeftPaneComposePropsType> {
private readonly composeContacts: ReadonlyArray<ContactListItemPropsType>;

2
ts/components/leftPane/LeftPaneHelper.tsx
View file

@ -21,8 +21,6 @@ export type ToFindType = {
unreadOnly: boolean;
};
/* eslint-disable class-methods-use-this */
export abstract class LeftPaneHelper<T> {
getHeaderContents(
_: Readonly<{

2
ts/components/leftPane/LeftPaneInboxHelper.tsx
View file

@ -23,8 +23,6 @@ export type LeftPaneInboxPropsType = {
startSearchCounter: number;
};
/* eslint-disable class-methods-use-this */
export class LeftPaneInboxHelper extends LeftPaneHelper<LeftPaneInboxPropsType> {
private readonly conversations: ReadonlyArray<ConversationListItemPropsType>;

5
ts/components/leftPane/LeftPaneSearchHelper.tsx
View file

@ -43,8 +43,6 @@ const searchResultKeys: Array<
'conversationResults' | 'contactResults' | 'messageResults'
> = ['conversationResults', 'contactResults', 'messageResults'];
/* eslint-disable class-methods-use-this */
export class LeftPaneSearchHelper extends LeftPaneHelper<LeftPaneSearchPropsType> {
private readonly conversationResults: MaybeLoadedSearchResultsType<ConversationListItemPropsType>;
@ -144,7 +142,6 @@ export class LeftPaneSearchHelper extends LeftPaneHelper<LeftPaneSearchPropsType
}
// This is currently unimplemented. See DESKTOP-1170.
// eslint-disable-next-line class-methods-use-this
getRowIndexToScrollTo(
_selectedConversationId: undefined | string
): undefined | number {
@ -256,7 +253,6 @@ export class LeftPaneSearchHelper extends LeftPaneHelper<LeftPaneSearchPropsType
}
// This is currently unimplemented. See DESKTOP-1170.
// eslint-disable-next-line class-methods-use-this
getConversationAndMessageAtIndex(
_conversationIndex: number
): undefined | { conversationId: string; messageId?: string } {
@ -264,7 +260,6 @@ export class LeftPaneSearchHelper extends LeftPaneHelper<LeftPaneSearchPropsType
}
// This is currently unimplemented. See DESKTOP-1170.
// eslint-disable-next-line class-methods-use-this
getConversationAndMessageInDirection(
_toFind: Readonly<ToFindType>,
_selectedConversationId: undefined | string,

2
ts/components/leftPane/LeftPaneSetGroupMetadataHelper.tsx
View file

@ -36,8 +36,6 @@ export type LeftPaneSetGroupMetadataPropsType = {
userAvatarData: ReadonlyArray<AvatarDataType>;
};
/* eslint-disable class-methods-use-this */
export class LeftPaneSetGroupMetadataHelper extends LeftPaneHelper<LeftPaneSetGroupMetadataPropsType> {
private readonly groupAvatar: undefined | Uint8Array;