mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Avoid foreign key error if message is deleted before saving attachments

Browse source
This commit is contained in:
trevor-signal 2025-09-17 13:38:34 -04:00 • committed by GitHub
commit c98a346b0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ts/sql/Server.ts
View file

@ -2997,10 +2997,6 @@ function saveMessage(
} satisfies Omit<MessageTypeUnhydrated, 'json'>; } satisfies Omit<MessageTypeUnhydrated, 'json'>;
if (id && !forceSave) { if (id && !forceSave) {
if (normalizeAttachmentData) {
saveMessageAttachments(db, message);
}
const result = db const result = db
.prepare( .prepare(
// UPDATE queries that set the value of a primary key column can be very slow when // UPDATE queries that set the value of a primary key column can be very slow when
@ -3019,6 +3015,10 @@ function saveMessage(
return id; return id;
} }
if (normalizeAttachmentData) {
saveMessageAttachments(db, message);
}
if (jobToInsert) { if (jobToInsert) {
insertJob(db, jobToInsert); insertJob(db, jobToInsert);
} }