mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Switch to qrcode-generator library

Browse source
This commit is contained in:
Evan Hahn 2022-01-05 11:59:59 -06:00 • committed by GitHub
parent 17bee00821
commit c8d32f0327
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 155 additions and 696 deletions
Download patch file Download diff file Expand all files Collapse all files

48
ts/util/lint/exceptions.json
View file

@ -76,22 +76,6 @@
"updated": "2018-09-15T00:16:19.197Z",
"line": " Module['load'] = function load(f) {"
},
{
"rule": "DOM-innerHTML",
"path": "components/qrcode/qrcode.js",
"line": "\t\t\tthis._el.innerHTML = '';",
"reasonCategory": "usageTrusted",
"updated": "2018-09-15T00:38:04.183Z",
"reasonDetail": "Hard-coded string"
},
{
"rule": "DOM-innerHTML",
"path": "components/qrcode/qrcode.js",
"line": "\t\t\t_el.innerHTML = aHTML.join('');",
"reasonCategory": "usageTrusted",
"updated": "2018-09-18T19:19:27.699Z",
"reasonDetail": "Very limited in what HTML can be injected - dark/light options specify colors for the light/dark parts of QRCode"
},
{
"rule": "jQuery-append(",
"path": "node_modules/@discoveryjs/json-ext/dist/json-ext.js",
@ -5135,6 +5119,22 @@
"reasonCategory": "falseMatch",
"updated": "2018-09-15T00:38:04.183Z"
},
{
"rule": "DOM-document.write(",
"path": "node_modules/qrcode-generator/sample.js",
"line": " document.write(create_qrcode(text, typeNumber, errorCorrectionLevel) );",
"reasonCategory": "notExercisedByOurApp",
"updated": "2022-01-04T20:32:10.596Z",
"reasonDetail": "Sample code never required by us."
},
{
"rule": "DOM-innerHTML",
"path": "node_modules/qrcode-generator/sample.js",
"line": " document.getElementById('qr').innerHTML =",
"reasonCategory": "notExercisedByOurApp",
"updated": "2022-01-04T20:32:10.596Z",
"reasonDetail": "Sample code never required by us."
},
{
"rule": "jQuery-insertBefore(",
"path": "node_modules/quill/blots/block.js",
@ -7482,6 +7482,14 @@
"reasonCategory": "usageTrusted",
"updated": "2021-07-30T16:57:33.618Z"
},
{
"rule": "React-useRef",
"path": "ts/components/QrCode.tsx",
"line": " const canvasRef = useRef<null | HTMLCanvasElement>(null);",
"reasonCategory": "usageTrusted",
"updated": "2022-01-04T21:43:17.517Z",
"reasonDetail": "Used to draw on the canvas."
},
{
"rule": "React-createRef",
"path": "ts/components/SafetyNumberChangeDialog.js",
@ -7757,14 +7765,6 @@
"updated": "2021-12-06T23:07:28.947Z",
"reasonDetail": "Doesn't touch the DOM."
},
{
"rule": "React-useRef",
"path": "ts/components/installScreen/InstallScreenQrCodeNotScannedStep.tsx",
"line": " const qrCodeElRef = useRef<null | HTMLDivElement>(null);",
"reasonCategory": "usageTrusted",
"updated": "2021-12-06T23:07:28.947Z",
"reasonDetail": "Uses our QR code library."
},
{
"rule": "React-createRef",
"path": "ts/components/stickers/StickerManager.js",

3
ts/util/lint/license_comments.ts
View file

@ -1,4 +1,4 @@
// Copyright 2020 Signal Messenger, LLC
// Copyright 2020-2022 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
// This file doesn't check the format of license files, just the end year. See
@ -39,7 +39,6 @@ const FILES_TO_IGNORE = new Set(
'.github/ISSUE_TEMPLATE/bug_report.md',
'.github/PULL_REQUEST_TEMPLATE.md',
'components/mp3lameencoder/lib/Mp3LameEncoder.js',
'components/qrcode/qrcode.js',
'components/recorderjs/recorder.js',
'components/recorderjs/recorderWorker.js',
'components/webaudiorecorder/lib/WebAudioRecorder.js',