mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Cleanup normalizeGroupCallTimestamp non-number handling

Browse source
This commit is contained in:
ayumi-signal 2024-07-23 08:43:44 -07:00 • committed by GitHub
parent 168397d8ef
commit c70a8955f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

25
ts/util/ringrtc/normalizeGroupCallTimestamp.ts
View file

@ -2,31 +2,12 @@
// SPDX-License-Identifier: AGPL-3.0-only
/**
* Normalizes group call timestamps (`addedTime` and `speakerTime`) into numbers. We
* expect RingRTC to send a string, but it sends a malformed number as of this writing,
* RingRTC 2.8.3.
*
* We could probably safely do `Number(fromRingRtc)` and be done, but this is extra-
* careful.
* Normalizes RingRTC group call timestamps (`addedTime` and `speakerTime`) into numbers.
*/
export function normalizeGroupCallTimestamp(
fromRingRtc: unknown
fromRingRtc: string
): undefined | number {
let asNumber: number;
switch (typeof fromRingRtc) {
case 'number':
asNumber = fromRingRtc;
break;
case 'string':
asNumber = parseInt(fromRingRtc.slice(0, 15), 10);
break;
case 'bigint':
asNumber = Number(fromRingRtc);
break;
default:
return undefined;
}
const asNumber = parseInt(fromRingRtc.slice(0, 15), 10);
if (Number.isNaN(asNumber) || asNumber <= 0) {
return undefined;