Enable calling raise hand

This commit is contained in:
ayumi-signal 2024-05-28 19:51:55 -07:00 committed by GitHub
parent 4ec69ee3a0
commit c67a346218
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 1 additions and 20 deletions

View file

@ -75,7 +75,6 @@ const createProps = (storyProps: Partial<PropsType> = {}): PropsType => ({
i18n,
incomingCall: null,
callLink: undefined,
isGroupCallRaiseHandEnabled: true,
me: {
...getDefaultConversation({
color: AvatarColors[0],

View file

@ -106,7 +106,6 @@ export type PropsType = {
denyUser: (payload: PendingUserActionPayloadType) => void;
hasInitialLoadCompleted: boolean;
i18n: LocalizerType;
isGroupCallRaiseHandEnabled: boolean;
me: ConversationType;
notifyForCall: (
conversationId: string,
@ -166,7 +165,6 @@ function ActiveCallManager({
denyUser,
hangUpActiveCall,
i18n,
isGroupCallRaiseHandEnabled,
getGroupCallVideoFrameSource,
getPresentingSources,
me,
@ -429,7 +427,6 @@ function ActiveCallManager({
i18n={i18n}
imageDataCache={imageDataCache}
isCallLinkAdmin={isCallLinkAdmin}
isGroupCallRaiseHandEnabled={isGroupCallRaiseHandEnabled}
me={me}
openSystemPreferencesAction={openSystemPreferencesAction}
renderEmojiPicker={renderEmojiPicker}
@ -504,7 +501,6 @@ export function CallManager({
i18n,
incomingCall,
isConversationTooBigToRing,
isGroupCallRaiseHandEnabled,
me,
notifyForCall,
openSystemPreferencesAction,
@ -593,7 +589,6 @@ export function CallManager({
getPresentingSources={getPresentingSources}
hangUpActiveCall={hangUpActiveCall}
i18n={i18n}
isGroupCallRaiseHandEnabled={isGroupCallRaiseHandEnabled}
me={me}
openSystemPreferencesAction={openSystemPreferencesAction}
pauseVoiceNotePlayer={pauseVoiceNotePlayer}

View file

@ -193,7 +193,6 @@ const createProps = (
i18n,
imageDataCache: React.createRef<CallingImageDataCache>(),
isCallLinkAdmin: true,
isGroupCallRaiseHandEnabled: true,
me: getDefaultConversation({
color: AvatarColors[1],
id: '6146087e-f7ef-457e-9a8d-47df1fdd6b25',

View file

@ -103,7 +103,6 @@ export type PropsType = {
i18n: LocalizerType;
imageDataCache: React.RefObject<CallingImageDataCache>;
isCallLinkAdmin: boolean;
isGroupCallRaiseHandEnabled: boolean;
me: ConversationType;
openSystemPreferencesAction: () => unknown;
renderReactionPicker: (
@ -195,7 +194,6 @@ export function CallScreen({
i18n,
imageDataCache,
isCallLinkAdmin,
isGroupCallRaiseHandEnabled,
me,
openSystemPreferencesAction,
renderEmojiPicker,
@ -908,7 +906,7 @@ export function CallScreen({
onClick={toggleAudio}
tooltipDirection={TooltipPlacement.Top}
/>
{isGroupCallRaiseHandEnabled && raiseHandButtonType && (
{raiseHandButtonType && (
<CallingButton
buttonType={raiseHandButtonType}
i18n={i18n}

View file

@ -37,7 +37,6 @@ import type { AciString } from '../../types/ServiceId';
import { strictAssert } from '../../util/assert';
import { callLinkToConversation } from '../../util/callLinks';
import { callingTones } from '../../util/callingTones';
import { isGroupCallRaiseHandEnabled } from '../../util/isGroupCallRaiseHandEnabled';
import { missingCaseError } from '../../util/missingCaseError';
import { useAudioPlayerActions } from '../ducks/audioPlayer';
import { getActiveCall, useCallingActions } from '../ducks/calling';
@ -475,7 +474,6 @@ export const SmartCallManager = memo(function SmartCallManager() {
i18n={i18n}
incomingCall={incomingCall}
isConversationTooBigToRing={isConversationTooBigToRing}
isGroupCallRaiseHandEnabled={isGroupCallRaiseHandEnabled()}
me={me}
notifyForCall={notifyForCall}
openSystemPreferencesAction={openSystemPreferencesAction}

View file

@ -1,8 +0,0 @@
// Copyright 2023 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
import * as RemoteConfig from '../RemoteConfig';
export function isGroupCallRaiseHandEnabled(): boolean {
return Boolean(RemoteConfig.isEnabled('desktop.internalUser'));
}