From c535ed6c9e8d747f7eb3b0151fcf724818804ba6 Mon Sep 17 00:00:00 2001
From: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
Date: Fri, 23 Aug 2024 14:53:13 -0700
Subject: [PATCH] Update strings to make direct refs to buttons

---
 _locales/en/messages.json    |  8 ++++++++
 ts/components/CallsTab.tsx   | 11 +++--------
 ts/components/StoriesTab.tsx | 11 +++--------
 3 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/_locales/en/messages.json b/_locales/en/messages.json
index 2f1d2b55e5b4..10c87584bab0 100644
--- a/_locales/en/messages.json
+++ b/_locales/en/messages.json
@@ -6475,6 +6475,10 @@
   },
   "icu:Stories__placeholder-with-icon--text": {
     "messageformat": "Click <newStoryIcon>Add a story</newStoryIcon> to add an update.",
+    "description": "(Deleted 2024/08/22) Placeholder label for the story view"
+  },
+  "icu:Stories__placeholder-with-icon--text-2": {
+    "messageformat": "Click <newStoryButtonIcon></newStoryButtonIcon> to add an update.",
     "description": "Placeholder label for the story view"
   },
   "icu:Stories__from-to-group": {
@@ -7199,6 +7203,10 @@
   },
   "icu:CallsTab__EmptyStateText--with-icon": {
     "messageformat": "Click <newCallIcon>New Call</newCallIcon> to start a new voice or video call.",
+    "description": "(Deleted 2024/08/22) Calls Tab > When no call is selected > Empty state > Call to action text"
+  },
+  "icu:CallsTab__EmptyStateText--with-icon-2": {
+    "messageformat": "Click <newCallButtonIcon></newCallButtonIcon> to start a new voice or video call.",
     "description": "Calls Tab > When no call is selected > Empty state > Call to action text"
   },
   "icu:CallsList__SearchInputPlaceholder": {
diff --git a/ts/components/CallsTab.tsx b/ts/components/CallsTab.tsx
index 18264db15820..f04e150866dd 100644
--- a/ts/components/CallsTab.tsx
+++ b/ts/components/CallsTab.tsx
@@ -319,19 +319,14 @@ export function CallsTab({
             <p className="CallsTab__EmptyStateLabel">
               <I18n
                 i18n={i18n}
-                id="icu:CallsTab__EmptyStateText--with-icon"
+                id="icu:CallsTab__EmptyStateText--with-icon-2"
                 components={{
                   // eslint-disable-next-line react/no-unstable-nested-components
-                  newCallIcon: children => {
-                    let label: string | undefined;
-                    const first = children[0];
-                    if (typeof first === 'string') {
-                      label = first;
-                    }
+                  newCallButtonIcon: () => {
                     return (
                       <span
                         className="CallsTab__EmptyState__ActionIcon"
-                        aria-label={label}
+                        aria-label={i18n('icu:CallsTab__NewCallActionLabel')}
                       />
                     );
                   },
diff --git a/ts/components/StoriesTab.tsx b/ts/components/StoriesTab.tsx
index 6860ada8ed0b..5aee282f51e0 100644
--- a/ts/components/StoriesTab.tsx
+++ b/ts/components/StoriesTab.tsx
@@ -225,19 +225,14 @@ export function StoriesTab({
           ) : (
             <I18n
               i18n={i18n}
-              id="icu:Stories__placeholder-with-icon--text"
+              id="icu:Stories__placeholder-with-icon--text-2"
               components={{
                 // eslint-disable-next-line react/no-unstable-nested-components
-                newStoryIcon: children => {
-                  let label: string | undefined;
-                  const first = children[0];
-                  if (typeof first === 'string') {
-                    label = first;
-                  }
+                newStoryButtonIcon: () => {
                   return (
                     <span
                       className="Stories__placeholder__text__action"
-                      aria-label={label}
+                      aria-label={i18n('icu:Stories__add')}
                     />
                   );
                 },