mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Simplify sqlJoin required arguments

Browse source
This commit is contained in:
trevor-signal 2023-11-22 17:48:53 -05:00 • committed by GitHub
parent e87873c929
commit c3248be854
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ts/sql/util.ts
View file

@ -105,9 +105,9 @@ export function sqlConstant(value: QueryTemplateParam): QueryFragment {
/**
* Like `Array.prototype.join`, but for SQL fragments.
*/
const SQL_JOIN_SEPARATOR = ',';
export function sqlJoin(
items: ReadonlyArray<QueryFragmentValue>,
separator: string
items: ReadonlyArray<QueryFragmentValue>
): QueryFragment {
let query = '';
const params: Array<QueryTemplateParam> = [];
@ -118,7 +118,7 @@ export function sqlJoin(
params.push(...fragmentParams);
if (index < items.length - 1) {
query += separator;
query += SQL_JOIN_SEPARATOR;
}
});
@ -344,7 +344,7 @@ export function removeById<Key extends string | number>(
const removeByIdsSync = (ids: ReadonlyArray<string | number>): void => {
const [query, params] = sql`
DELETE FROM ${table}
WHERE id IN (${sqlJoin(ids, ', ')});
WHERE id IN (${sqlJoin(ids)});
`;
totalChanges += db.prepare(query).run(params).changes;
};