mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix remote config for configs with unspecified on-off values

Browse source
This commit is contained in:
ayumi-signal 2025-09-02 16:42:04 -07:00 • committed by GitHub
commit c09dc17867
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
ts/test-node/RemoteConfig_test.ts
View file

@ -139,6 +139,20 @@ describe('RemoteConfig', () => {
assert.equal(isEnabled('desktop.internalUser'), true);
});
it('is true for true string flag', async () => {
await updateRemoteConfig([
{ name: 'desktop.internalUser', value: 'true' },
]);
assert.equal(isEnabled('desktop.internalUser'), true);
});
it('is false for false string flag', async () => {
await updateRemoteConfig([
{ name: 'desktop.internalUser', value: 'false' },
]);
assert.equal(isEnabled('desktop.internalUser'), false);
});
it('reflects the value of an unknown flag in the config', async () => {
assert.equal(
isEnabled('desktop.unknownFlagName' as ConfigKeyType),