Responding to pull request review feedback

- messages.getQuoteObjectUrl: early return
- backup.js: explaining variables for long if statement
- types/messages.js: Log if thumbnail has neither data nor path
- sendmessage.js:
  - remove extraneous logging
  - fix indentation
  - upload attachments and thumbnails in parallel
- preload: don't load fs for tests, just fse
- _conversation.scss: split two selectors into two lines, 0px -> 0
- backup_test.js: use fse.existsSync and comment twoSlashes regex
- network_tests_view_test.js: Comment duplicate assignment to window.getSocketStatus
This commit is contained in:
Scott Nonnenberg 2018-04-23 15:36:47 -07:00
parent 6ec6bf08c8
commit c02860af5c
No known key found for this signature in database
GPG key ID: 5F82280C35134661
8 changed files with 34 additions and 18 deletions

View file

@ -14,6 +14,11 @@ describe('NetworkStatusView', function() {
after(function() {
window.getSocketStatus = oldGetSocketStatus;
// It turns out that continued calls to window.getSocketStatus happen
// because we host NetworkStatusView in three mock interfaces, and the view
// checks every N seconds. That results in infinite errors unless there is
// something to call.
window.getSocketStatus = function() { return WebSocket.OPEN; };
});
/* END stubbing globals */