Calling selectors are now based on the root state

ts/state/ducks/calling.ts

@@ -89,10 +89,12 @@ export interface ActiveCallStateType {
   settingsDialogOpen: boolean;
 }
 
+export interface CallsByConversationType {
+  [conversationId: string]: DirectCallStateType | GroupCallStateType;
+}
+
 export type CallingStateType = MediaDeviceSettings & {
-  callsByConversation: {
+  callsByConversation: CallsByConversationType;
-    [conversationId: string]: DirectCallStateType | GroupCallStateType;
-  };
   activeCallState?: ActiveCallStateType;
 };
 

ts/state/selectors/calling.ts

@@ -3,17 +3,29 @@
 
 import { createSelector } from 'reselect';
 
-import { CallingStateType, DirectCallStateType } from '../ducks/calling';
+import { StateType } from '../reducer';
+import {
+  CallingStateType,
+  CallsByConversationType,
+  DirectCallStateType,
+} from '../ducks/calling';
 import { CallMode, CallState } from '../../types/Calling';
 
-const getCallsByConversation = (state: CallingStateType) =>
+const getCalling = (state: StateType): CallingStateType => state.calling;
-  state.callsByConversation;
+
+const getCallsByConversation = createSelector(
+  getCalling,
+  (state: CallingStateType): CallsByConversationType =>
+    state.callsByConversation
+);
 
 // In theory, there could be multiple incoming calls. In practice, neither RingRTC nor the
 //   UI are ready to handle this.
 export const getIncomingCall = createSelector(
   getCallsByConversation,
-  (callsByConversation): undefined | DirectCallStateType => {
+  (
+    callsByConversation: CallsByConversationType
+  ): undefined | DirectCallStateType => {
     const result = Object.values(callsByConversation).find(
       call =>
         call.callMode === CallMode.Direct &&

ts/state/smart/CallManager.tsx

@@ -124,7 +124,7 @@ const mapStateToActiveCallProp = (state: StateType) => {
 };
 
 const mapStateToIncomingCallProp = (state: StateType) => {
-  const call = getIncomingCall(state.calling);
+  const call = getIncomingCall(state);
   if (!call) {
     return undefined;
   }

ts/test-electron/state/selectors/calling_test.ts

@@ -2,11 +2,20 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 import { assert } from 'chai';
+import { reducer as rootReducer } from '../../../state/reducer';
+import { noopAction } from '../../../state/ducks/noop';
 import { CallMode, CallState } from '../../../types/Calling';
 import { getIncomingCall } from '../../../state/selectors/calling';
 import { getEmptyState, CallingStateType } from '../../../state/ducks/calling';
 
 describe('state/selectors/calling', () => {
+  const getEmptyRootState = () => rootReducer(undefined, noopAction());
+
+  const getCallingState = (calling: CallingStateType) => ({
+    ...getEmptyRootState(),
+    calling,
+  });
+
   const stateWithDirectCall: CallingStateType = {
     ...getEmptyState(),
     callsByConversation: {
@@ -49,23 +58,28 @@ describe('state/selectors/calling', () => {
 
   describe('getIncomingCall', () => {
     it('returns undefined if there are no calls', () => {
-      assert.isUndefined(getIncomingCall(getEmptyState()));
+      assert.isUndefined(getIncomingCall(getEmptyRootState()));
     });
 
     it('returns undefined if there is no incoming call', () => {
-      assert.isUndefined(getIncomingCall(stateWithDirectCall));
+      assert.isUndefined(getIncomingCall(getCallingState(stateWithDirectCall)));
-      assert.isUndefined(getIncomingCall(stateWithActiveDirectCall));
+      assert.isUndefined(
+        getIncomingCall(getCallingState(stateWithActiveDirectCall))
+      );
     });
 
     it('returns the incoming call', () => {
-      assert.deepEqual(getIncomingCall(stateWithIncomingDirectCall), {
+      assert.deepEqual(
-        callMode: CallMode.Direct,
+        getIncomingCall(getCallingState(stateWithIncomingDirectCall)),
-        conversationId: 'fake-direct-call-conversation-id',
+        {
-        callState: CallState.Ringing,
+          callMode: CallMode.Direct,
-        isIncoming: true,
+          conversationId: 'fake-direct-call-conversation-id',
-        isVideoCall: false,
+          callState: CallState.Ringing,
-        hasRemoteVideo: false,
+          isIncoming: true,
-      });
+          isVideoCall: false,
+          hasRemoteVideo: false,
+        }
+      );
     });
   });
 });