Key cleanup before migration 88 and attempt vacuum only once in 920

ts/sql/migrations/87-cleanup.ts

@@ -0,0 +1,54 @@
+// Copyright 2023 Signal Messenger, LLC
+// SPDX-License-Identifier: AGPL-3.0-only
+
+import type { Database } from '@signalapp/better-sqlite3';
+
+import type { LoggerType } from '../../types/Logging';
+import { cleanKeys } from './920-clean-more-keys';
+import { sqlFragment } from '../util';
+
+// Note: for many users, this is not what ran for them as migration 87. You can see that
+//   migration here: https://github.com/signalapp/Signal-Desktop/commit/671e16ae1f869627f355113d6397ccb62d5461d2
+
+// The goal of this migration is to ensure that key cleanup happens before migration 88.
+
+export default function updateToSchemaVersion87(
+  currentVersion: number,
+  db: Database,
+  logger: LoggerType
+): void {
+  // We're checking for the version of the next migration here, not this version. We want
+  //   this to run if the user hasn't yet successfully run migration 88.
+  if (currentVersion >= 88) {
+    return;
+  }
+
+  db.transaction(() => {
+    cleanKeys(
+      db,
+      logger,
+      'updateToSchemaVersion87(cleanup)/kyberPreKeys',
+      sqlFragment`kyberPreKeys`,
+      sqlFragment`createdAt`,
+      sqlFragment`ourUuid`
+    );
+    cleanKeys(
+      db,
+      logger,
+      'updateToSchemaVersion87(cleanup)/preKeys',
+      sqlFragment`preKeys`,
+      sqlFragment`createdAt`,
+      sqlFragment`ourUuid`
+    );
+    cleanKeys(
+      db,
+      logger,
+      'updateToSchemaVersion87(cleanup)/signedPreKeys',
+      sqlFragment`signedPreKeys`,
+      sqlFragment`created_at`,
+      sqlFragment`ourUuid`
+    );
+  })();
+
+  logger.info('updateToSchemaVersion87(cleanup): success!');
+}