Ensure that context is always provided for error logs

This commit is contained in:
Scott Nonnenberg 2021-05-19 15:00:57 -07:00
parent 7418a5c663
commit be087c3498
5 changed files with 18 additions and 5 deletions

View file

@ -1527,7 +1527,10 @@ ipc.handle('show-calling-permissions-popup', async (event, forCamera) => {
try { try {
await showPermissionsPopupWindow(true, forCamera); await showPermissionsPopupWindow(true, forCamera);
} catch (error) { } catch (error) {
console.error(error); console.error(
'show-calling-permissions-popup error:',
error && error.stack ? error.stack : error
);
} }
}); });
ipc.on('close-permissions-popup', () => { ipc.on('close-permissions-popup', () => {

View file

@ -60,7 +60,9 @@ export const CallingNotification: React.FC<PropsType> = React.memo(props => {
callType = 'video'; callType = 'video';
break; break;
default: default:
window.log.error(missingCaseError(props)); window.log.error(
`CallingNotification missing case: ${missingCaseError(props)}`
);
return null; return null;
} }

View file

@ -865,7 +865,11 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
}; };
} }
default: default:
window.log.error(missingCaseError(callHistoryDetails)); window.log.error(
`getPropsForCallHistory: missing case ${missingCaseError(
callHistoryDetails
)}`
);
return undefined; return undefined;
} }
} }

View file

@ -16,6 +16,6 @@ export function assert(condition: unknown, message: string): asserts condition {
} }
throw err; throw err;
} }
log.error(err); log.error('assert failure:', err && err.stack ? err.stack : err);
} }
} }

View file

@ -102,7 +102,11 @@ export function getCallingNotificationText(
case CallMode.Group: case CallMode.Group:
return getGroupCallNotificationText(notification, i18n); return getGroupCallNotificationText(notification, i18n);
default: default:
window.log.error(missingCaseError(notification)); window.log.error(
`getCallingNotificationText: missing case ${missingCaseError(
notification
)}`
);
return ''; return '';
} }
} }