mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Ensure that context is always provided for error logs

Browse source
This commit is contained in:
Scott Nonnenberg 2021-05-19 15:00:57 -07:00
parent 7418a5c663
commit be087c3498
5 changed files with 18 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ts/components/conversation/CallingNotification.tsx
View file

@ -60,7 +60,9 @@ export const CallingNotification: React.FC<PropsType> = React.memo(props => {
callType = 'video';
break;
default:
window.log.error(missingCaseError(props));
window.log.error(
`CallingNotification missing case: ${missingCaseError(props)}`
);
return null;
}

6
ts/models/messages.ts
View file

@ -865,7 +865,11 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
};
}
default:
window.log.error(missingCaseError(callHistoryDetails));
window.log.error(
`getPropsForCallHistory: missing case ${missingCaseError(
callHistoryDetails
)}`
);
return undefined;
}
}

2
ts/util/assert.ts
View file

@ -16,6 +16,6 @@ export function assert(condition: unknown, message: string): asserts condition {
}
throw err;
}
log.error(err);
log.error('assert failure:', err && err.stack ? err.stack : err);
}
}

6
ts/util/callingNotification.ts
View file

@ -102,7 +102,11 @@ export function getCallingNotificationText(
case CallMode.Group:
return getGroupCallNotificationText(notification, i18n);
default:
window.log.error(missingCaseError(notification));
window.log.error(
`getCallingNotificationText: missing case ${missingCaseError(
notification
)}`
);
return '';
}
}