mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions 1

Move receipts and view/read syncs to new syncTasks system

Browse source 
Co-authored-by: Scott Nonnenberg <scott@signal.org>
This commit is contained in:
automated-signal 2024-06-17 19:36:57 -05:00 • committed by GitHub
parent 949104c316
commit b95dd1a70f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
33 changed files with 1242 additions and 612 deletions
Download patch file Download diff file Expand all files Collapse all files

26
ts/models/conversations.ts
View file

@ -2945,6 +2945,13 @@ export class ConversationModel extends window.Backbone
senderAci,
});
if (!this.get('active_at')) {
log.warn(
`addDeliveryIssue: ${this.idForLogging()} has no active_at, dropping delivery issue instead of adding`
);
return;
}
const message = {
conversationId: this.id,
type: 'delivery-issue',
@ -3363,7 +3370,9 @@ export class ConversationModel extends window.Backbone
const message = window.MessageCache.__DEPRECATED$getById(notificationId);
if (message) {
await window.Signal.Data.removeMessage(message.id);
await window.Signal.Data.removeMessage(message.id, {
singleProtoJobQueue,
});
}
return true;
}
@ -3404,7 +3413,9 @@ export class ConversationModel extends window.Backbone
const message = window.MessageCache.__DEPRECATED$getById(notificationId);
if (message) {
await window.Signal.Data.removeMessage(message.id);
await window.Signal.Data.removeMessage(message.id, {
singleProtoJobQueue,
});
}
return true;
@ -5003,7 +5014,14 @@ export class ConversationModel extends window.Backbone
});
window.Signal.Data.updateConversation(this.attributes);
if (source === 'local-delete' && isEnabled('desktop.deleteSync.send')) {
const ourConversation =
window.ConversationController.getOurConversationOrThrow();
const capable = Boolean(ourConversation.get('capabilities')?.deleteSync);
if (
source === 'local-delete' &&
capable &&
isEnabled('desktop.deleteSync.send')
) {
log.info(`${logId}: Preparing sync message`);
const timestamp = Date.now();
@ -5044,7 +5062,9 @@ export class ConversationModel extends window.Backbone
log.info(`${logId}: Starting delete`);
await window.Signal.Data.removeMessagesInConversation(this.id, {
fromSync: source !== 'local-delete-sync',
logId: this.idForLogging(),
singleProtoJobQueue,
});
log.info(`${logId}: Delete complete`);
}

6
ts/models/messages.ts
View file

@ -109,7 +109,7 @@ import {
} from '../services/notifications';
import type { LinkPreviewType } from '../types/message/LinkPreviews';
import * as log from '../logging/log';
import { cleanupMessage, deleteMessageData } from '../util/cleanup';
import { deleteMessageData } from '../util/cleanup';
import {
getSource,
getSourceServiceId,
@ -315,10 +315,6 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
this.set(attributes);
}
async cleanup(): Promise<void> {
await cleanupMessage(this.attributes);
}
async deleteData(): Promise<void> {
await deleteMessageData(this.attributes);
}