mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Remove runtime type checks from calling service

Browse source
This commit is contained in:
Evan Hahn 2020-11-02 12:08:31 -06:00 • committed by Evan Hahn
parent cfc3c123bc
commit b7a1ddf628
1 changed files with 0 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

23
ts/services/calling.ts
View file

@ -21,9 +21,6 @@ import {
UserId, UserId,
} from 'ringrtc'; } from 'ringrtc';
// ts-ignore
import is from '@sindresorhus/is';
import { import {
ActionsType as UxActionsType, ActionsType as UxActionsType,
CallDetailsType, CallDetailsType,
@ -61,26 +58,6 @@ export class CallingClass {
if (!uxActions) { if (!uxActions) {
throw new Error('CallingClass.initialize: Invalid uxActions.'); throw new Error('CallingClass.initialize: Invalid uxActions.');
} }
if (!is.function_(uxActions.incomingCall)) {
throw new Error(
'CallingClass.initialize: Invalid uxActions.incomingCall'
);
}
if (!is.function_(uxActions.outgoingCall)) {
throw new Error(
'CallingClass.initialize: Invalid uxActions.outgoingCall'
);
}
if (!is.function_(uxActions.callStateChange)) {
throw new Error(
'CallingClass.initialize: Invalid uxActions.callStateChange'
);
}
if (!is.function_(uxActions.remoteVideoChange)) {
throw new Error(
'CallingClass.initialize: Invalid uxActions.remoteVideoChange'
);
}
RingRTC.handleOutgoingSignaling = this.handleOutgoingSignaling.bind(this); RingRTC.handleOutgoingSignaling = this.handleOutgoingSignaling.bind(this);
RingRTC.handleIncomingCall = this.handleIncomingCall.bind(this); RingRTC.handleIncomingCall = this.handleIncomingCall.bind(this);
RingRTC.handleAutoEndedIncomingCallRequest = this.handleAutoEndedIncomingCallRequest.bind( RingRTC.handleAutoEndedIncomingCallRequest = this.handleAutoEndedIncomingCallRequest.bind(