From b483d26488c6f2531d135008cf383ad46b937d27 Mon Sep 17 00:00:00 2001
From: Alvaro <110414366+alvaro-signal@users.noreply.github.com>
Date: Tue, 21 Feb 2023 10:44:31 -0700
Subject: [PATCH] Fix i18n warning on empty string

---
 ts/components/conversation/MessageAudio.tsx | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/ts/components/conversation/MessageAudio.tsx b/ts/components/conversation/MessageAudio.tsx
index 3f1dc5f11fd..fb61f971e69 100644
--- a/ts/components/conversation/MessageAudio.tsx
+++ b/ts/components/conversation/MessageAudio.tsx
@@ -60,7 +60,6 @@ export type DispatchProps = Readonly<{
 export type Props = OwnProps & DispatchProps;
 
 type ButtonProps = {
-  i18n: LocalizerType;
   variant: 'play' | 'playback-rate';
   mod?: string;
   label: string;
@@ -129,7 +128,6 @@ const timeToText = (time: number): string => {
 const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
   function ButtonInner(props, ref) {
     const {
-      i18n,
       variant,
       mod,
       label,
@@ -189,8 +187,7 @@ const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
           onMouseUp={() => setIsDown(false)}
           onMouseLeave={() => setIsDown(false)}
           tabIndex={0}
-          // eslint-disable-next-line local-rules/valid-i18n-keys
-          aria-label={i18n(label)}
+          aria-label={label}
         >
           {children}
         </button>
@@ -517,7 +514,6 @@ export function MessageAudio(props: Props): JSX.Element {
     button = (
       <Button
         ref={buttonRef}
-        i18n={i18n}
         variant="play"
         mod="download"
         label="MessageAudio--download"
@@ -530,10 +526,11 @@ export function MessageAudio(props: Props): JSX.Element {
     button = (
       <Button
         ref={buttonRef}
-        i18n={i18n}
         variant="play"
         mod={isPlaying ? 'pause' : 'play'}
-        label={isPlaying ? 'MessageAudio--pause' : 'MessageAudio--play'}
+        label={
+          isPlaying ? i18n('MessageAudio--pause') : i18n('MessageAudio--play')
+        }
         animateClick={false}
         onClick={toggleIsPlaying}
       />
@@ -575,8 +572,7 @@ export function MessageAudio(props: Props): JSX.Element {
         />
         <Button
           variant="playback-rate"
-          i18n={i18n}
-          label={(active && playbackRateLabels[active.playbackRate]) ?? ''}
+          label={playbackRateLabels[active?.playbackRate ?? 1]}
           visible={isPlaying && (!played || !isPlayedDotVisible)}
           onClick={() => {
             if (active) {
@@ -587,7 +583,7 @@ export function MessageAudio(props: Props): JSX.Element {
             }
           }}
         >
-          {active && playbackRateLabels[active.playbackRate]}
+          {playbackRateLabels[active?.playbackRate ?? 1]}
         </Button>
       </div>