profileKey: Check length of incoming values, clear on failed send/fetch

This commit is contained in:
Scott Nonnenberg 2022-02-22 12:34:57 -08:00 committed by GitHub
parent b96c7e90fe
commit b33b5d2a30
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 284 additions and 56 deletions

View file

@ -1,4 +1,4 @@
// Copyright 2020-2021 Signal Messenger, LLC
// Copyright 2020-2022 Signal Messenger, LLC
// SPDX-License-Identifier: AGPL-3.0-only
/* eslint-disable no-bitwise */
@ -1824,7 +1824,10 @@ export default class MessageReceiver
}
if (msg.flags && msg.flags & Proto.DataMessage.Flags.PROFILE_KEY_UPDATE) {
strictAssert(msg.profileKey, 'PROFILE_KEY_UPDATE without profileKey');
strictAssert(
msg.profileKey && msg.profileKey.length > 0,
'PROFILE_KEY_UPDATE without profileKey'
);
const ev = new ProfileKeyUpdateEvent(
{