Cleanup RemoteConfig

ts/windows/preload.ts

@@ -31,10 +31,8 @@ installSetting('typingIndicatorSetting', {
 });
 
 installCallback('deleteAllMyStories');
-installCallback('isFormattingFlagEnabled');
 installCallback('isPhoneNumberSharingEnabled');
 installCallback('isPrimary');
-installCallback('shouldShowStoriesSettings');
 installCallback('syncRequest');
 
 installSetting('alwaysRelayCalls');
@@ -56,7 +54,6 @@ installSetting('notificationSetting');
 installSetting('spellCheck');
 installSetting('systemTraySetting');
 installSetting('sentMediaQualitySetting');
-installSetting('textFormatting');
 installSetting('themeSetting');
 installSetting('universalExpireTimer');
 installSetting('zoomFactor');

ts/windows/settings/app.tsx

@@ -59,7 +59,6 @@ SettingsWindowProps.onRender(
     initialSpellCheckSetting,
     isAutoDownloadUpdatesSupported,
     isAutoLaunchSupported,
-    isFormattingFlagEnabled,
     isHideMenuBarSupported,
     isMinimizeToAndStartInSystemTraySupported,
     isNotificationAttentionSupported,
@@ -111,7 +110,6 @@ SettingsWindowProps.onRender(
     selectedSpeaker,
     sentMediaQualitySetting,
     setGlobalDefaultConversationColor,
-    shouldShowStoriesSettings,
     localeOverride,
     themeSetting,
     universalExpireTimer,
@@ -163,7 +161,6 @@ SettingsWindowProps.onRender(
         initialSpellCheckSetting={initialSpellCheckSetting}
         isAutoDownloadUpdatesSupported={isAutoDownloadUpdatesSupported}
         isAutoLaunchSupported={isAutoLaunchSupported}
-        isFormattingFlagEnabled={isFormattingFlagEnabled}
         isHideMenuBarSupported={isHideMenuBarSupported}
         isMinimizeToAndStartInSystemTraySupported={
           isMinimizeToAndStartInSystemTraySupported
@@ -220,7 +217,6 @@ SettingsWindowProps.onRender(
         selectedSpeaker={selectedSpeaker}
         sentMediaQualitySetting={sentMediaQualitySetting}
         setGlobalDefaultConversationColor={setGlobalDefaultConversationColor}
-        shouldShowStoriesSettings={shouldShowStoriesSettings}
         themeSetting={themeSetting}
         universalExpireTimer={universalExpireTimer}
         whoCanFindMe={whoCanFindMe}

ts/windows/settings/preload.ts

@@ -79,13 +79,9 @@ const settingUniversalExpireTimer = createSetting('universalExpireTimer');
 // Callbacks
 const ipcGetAvailableIODevices = createCallback('getAvailableIODevices');
 const ipcGetCustomColors = createCallback('getCustomColors');
-const ipcIsFormattingFlagEnabled = createCallback('isFormattingFlagEnabled');
 const ipcIsSyncNotSupported = createCallback('isPrimary');
 const ipcMakeSyncRequest = createCallback('syncRequest');
 const ipcPNP = createCallback('isPhoneNumberSharingEnabled');
-const ipcShouldShowStoriesSettings = createCallback(
-  'shouldShowStoriesSettings'
-);
 const ipcDeleteAllMyStories = createCallback('deleteAllMyStories');
 
 // ChatColorPicker redux hookups
@@ -162,7 +158,6 @@ async function renderPreferences() {
     hasStoriesDisabled,
     hasTextFormatting,
     hasTypingIndicators,
-    isFormattingFlagEnabled,
     isPhoneNumberSharingSupported,
     lastSyncTime,
     notificationContent,
@@ -182,7 +177,6 @@ async function renderPreferences() {
     customColors,
     defaultConversationColor,
     isSyncNotSupported,
-    shouldShowStoriesSettings,
   } = await awaitObject({
     blockedCount: settingBlockedCount.getValue(),
     deviceName: settingDeviceName.getValue(),
@@ -224,9 +218,7 @@ async function renderPreferences() {
     availableIODevices: ipcGetAvailableIODevices(),
     customColors: ipcGetCustomColors(),
     defaultConversationColor: ipcGetDefaultConversationColor(),
-    isFormattingFlagEnabled: ipcIsFormattingFlagEnabled(),
     isSyncNotSupported: ipcIsSyncNotSupported(),
-    shouldShowStoriesSettings: ipcShouldShowStoriesSettings(),
   });
 
   const { availableCameras, availableMicrophones, availableSpeakers } =
@@ -306,7 +298,6 @@ async function renderPreferences() {
     resetAllChatColors: ipcResetAllChatColors,
     resetDefaultChatColor: ipcResetDefaultChatColor,
     setGlobalDefaultConversationColor: ipcSetGlobalDefaultConversationColor,
-    shouldShowStoriesSettings,
 
     // Limited support features
     isAutoDownloadUpdatesSupported: Settings.isAutoDownloadUpdatesSupported(OS),
@@ -325,9 +316,6 @@ async function renderPreferences() {
         MinimalSignalContext.getVersion()
       ),
 
-    // Feature flags
-    isFormattingFlagEnabled,
-
     // Change handlers
     onAudioNotificationsChange: attachRenderCallback(
       settingAudioNotification.setValue