mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Cleanup RemoteConfig

Browse source
This commit is contained in:
Fedor Indutny 2023-12-08 00:59:54 +01:00 • committed by GitHub
parent 7bad05f5a0
commit b2a3605d77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
53 changed files with 121 additions and 614 deletions
Download patch file Download diff file Expand all files Collapse all files

20
ts/test-both/RemoteConfig_test.ts
View file

@ -11,15 +11,15 @@ import {
} from '../RemoteConfig';
describe('RemoteConfig', () => {
const aci = normalizeAci('15b9729c-51ea-4ddb-b516-652befe78062', 'test');
const aci = normalizeAci('95b9729c-51ea-4ddb-b516-652befe78062', 'test');
describe('#innerIsBucketValueEnabled', () => {
// Note: bucketValue is 497941 for 'desktop.stories2' key
// Note: bucketValue is 627610 for 'desktop.pnp' key
it('returns true for 100% wildcard', () => {
assert.strictEqual(
innerIsBucketValueEnabled(
'desktop.stories2',
'desktop.pnp',
'*:1000000',
'+12125550000',
aci
@ -28,11 +28,11 @@ describe('RemoteConfig', () => {
);
});
it('returns true for 50% on country code 1', () => {
it('returns true for 70% on country code 1', () => {
assert.strictEqual(
innerIsBucketValueEnabled(
'desktop.stories2',
'1:500000',
'desktop.pnp',
'1:700000',
'+12125550000',
aci
),
@ -40,11 +40,11 @@ describe('RemoteConfig', () => {
);
});
it('returns false for 40% on country code 1', () => {
it('returns false for 50% on country code 1', () => {
assert.strictEqual(
innerIsBucketValueEnabled(
'desktop.stories2',
'1:400000',
'desktop.pnp',
'1:500000',
'+12125550000',
aci
),
@ -92,7 +92,7 @@ describe('RemoteConfig', () => {
it('returns undefined for empty value', () => {
const flagName = 'research.megaphone.1';
assert.strictEqual(getBucketValue(aci, flagName), 243315);
assert.strictEqual(getBucketValue(aci, flagName), 222732);
});
});
});