From b049412bfd8d13c5055324ceac5f305b7b680e0e Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Wed, 7 Mar 2018 15:19:02 -0500 Subject: [PATCH] Document workaround for `got` `FormData` bug See: https://github.com/sindresorhus/got/pull/466 --- js/modules/debuglogs.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/modules/debuglogs.js b/js/modules/debuglogs.js index f7173af43..44bb443f9 100644 --- a/js/modules/debuglogs.js +++ b/js/modules/debuglogs.js @@ -9,6 +9,7 @@ const BASE_URL = 'https://debuglogs.org'; // Workaround: Submitting `FormData` using native `FormData::submit` procedure // as integration with `got` results in S3 error saying we haven’t set the // `Content-Length` header: +// https://github.com/sindresorhus/got/pull/466 const submitFormData = (form, url) => new Promise((resolve, reject) => { form.submit(url, (error) => { @@ -42,6 +43,8 @@ exports.upload = async (content) => { filename: 'signal-desktop-debug-log.txt', }); + // WORKAROUND: See comment on `submitFormData`: + // await got.post(url, { body: form }); await submitFormData(form, url); return `${BASE_URL}/${fields.key}`;