mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Timeline: Use messageChangeCounter to mark messages read less often

Browse source
This commit is contained in:
Scott Nonnenberg 2022-05-11 15:41:45 -07:00 • committed by GitHub
parent 69d0ed3309
commit af2c884c9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 162 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
ts/components/conversation/Timeline.stories.tsx
View file

@ -542,6 +542,7 @@ const useProps = (overrideProps: Partial<PropsType> = {}): PropsType => ({
overrideProps.isIncomingMessageRequest === true
),
items: overrideProps.items || Object.keys(items),
messageChangeCounter: 0,
scrollToIndex: overrideProps.scrollToIndex,
scrollToIndexCounter: 0,
totalUnseen: number('totalUnseen', overrideProps.totalUnseen || 0),

6
ts/components/conversation/Timeline.tsx
View file

@ -86,6 +86,7 @@ export type ContactSpoofingReviewPropType =
export type PropsDataType = {
haveNewest: boolean;
haveOldest: boolean;
messageChangeCounter: number;
messageLoadingState?: TimelineMessageLoadingState;
isNearBottom?: boolean;
items: ReadonlyArray<string>;
@ -648,12 +649,14 @@ export class Timeline extends React.Component<
): void {
const {
items: oldItems,
messageChangeCounter: previousMessageChangeCounter,
messageLoadingState: previousMessageLoadingState,
} = prevProps;
const {
discardMessages,
id,
items: newItems,
messageChangeCounter,
messageLoadingState,
} = this.props;
@ -712,7 +715,8 @@ export class Timeline extends React.Component<
numberToKeepAtTop,
});
}
} else {
}
if (previousMessageChangeCounter !== messageChangeCounter) {
this.markNewestBottomVisibleMessageRead();
}
}