Retry outbound "normal" messages for up to a day

ts/test-node/jobs/JobQueueDatabaseStore_test.ts

@@ -92,6 +92,32 @@ describe('JobQueueDatabaseStore', () => {
       assert.deepEqual(events, ['insert', 'yielded job']);
     });
 
+    it('can skip the database', async () => {
+      const store = new JobQueueDatabaseStore(fakeDatabase);
+
+      const streamPromise = (async () => {
+        // We don't actually care about using the variable from the async iterable.
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
+        for await (const _job of store.stream('test queue')) {
+          break;
+        }
+      })();
+
+      await store.insert(
+        {
+          id: 'abc',
+          timestamp: 1234,
+          queueType: 'test queue',
+          data: { hi: 5 },
+        },
+        { shouldInsertIntoDatabase: false }
+      );
+
+      await streamPromise;
+
+      sinon.assert.notCalled(fakeDatabase.insertJob);
+    });
+
     it("doesn't insert jobs until the initial fetch has completed", async () => {
       const events: Array<string> = [];
 

ts/test-node/jobs/formatJobForInsert_test.ts

@@ -0,0 +1,27 @@
+// Copyright 2021 Signal Messenger, LLC
+// SPDX-License-Identifier: AGPL-3.0-only
+
+import { assert } from 'chai';
+
+import { formatJobForInsert } from '../../jobs/formatJobForInsert';
+
+describe('formatJobForInsert', () => {
+  it('removes non-essential properties', () => {
+    const input = {
+      id: 'abc123',
+      timestamp: 1234,
+      queueType: 'test queue',
+      data: { foo: 'bar' },
+      extra: 'ignored',
+      alsoIgnored: true,
+    };
+    const output = formatJobForInsert(input);
+
+    assert.deepEqual(output, {
+      id: 'abc123',
+      timestamp: 1234,
+      queueType: 'test queue',
+      data: { foo: 'bar' },
+    });
+  });
+});